feat: add sum of coupling

Author: manfredsteyer

apps/backend/src/services/change-coupling.spec.ts

@@ -54,6 +54,7 @@ describe('change coupling service', () => {
       [0, 0, 0],
     ]);
 
+    expect(result.sumOfCoupling).toEqual([4, 3, 3]);
     expect(result.fileCount).toEqual([3, 2, 2]);
   });
 });

apps/backend/src/services/change-coupling.ts

@@ -9,6 +9,7 @@ export type ChangeCouplingResult = {
   matrix: number[][];
   dimensions: string[];
   groups: string[];
+  sumOfCoupling: number[];
 
   fileCount: number[];
   cohesion: number[];
@@ -26,6 +27,7 @@ export async function calcChangeCoupling(
   const matrix = getEmptyMatrix(modules.length);
 
   const commitsPerModule: number[] = new Array(matrix.length).fill(0);
+  const sumOfCoupling: number[] = new Array(matrix.length).fill(0);
 
   const parseOptions: ParseOptions = {
     limits,
@@ -43,19 +45,34 @@ export async function calcChangeCoupling(
         }
       }
     }
+
+    updateSumOfCoupling(touchedModules, sumOfCoupling);
     addToMatrix(touchedModules, matrix);
   }, parseOptions);
 
   return {
     matrix,
     dimensions: displayModules,
     groups: config.groups,
-
+    sumOfCoupling,
     fileCount: commitsPerModule,
     cohesion: new Array(matrix.length).fill(-1),
   };
 }
 
+function updateSumOfCoupling(
+  touchedModules: Set<number>,
+  sumOfCoupling: number[]
+) {
+  const count = touchedModules.size;
+  if (count > 1) {
+    const otherModules = count - 1;
+    for (const module of touchedModules) {
+      sumOfCoupling[module] += otherModules;
+    }
+  }
+}
+
 function addToMatrix(touchedModules: Set<number>, matrix: number[][]) {
   const touchedArray = Array.from(touchedModules);
   for (const module1 of touchedArray) {

apps/backend/src/services/hotspot.spec.ts

@@ -41,6 +41,7 @@ jest.mock('../infrastructure/log', () => ({
 "Jane Doe <jane.doe@acme.com>,${now.toISOString()}"
 10\t0\t/booking/feature-manage/my.component.ts
 0\t1\t/checkin/feature-checkin/my.component.ts
+0\t1\t/shared/feature-checkin/my.component.md
 
 "John Doe <john.doe@acme.com>,${now.toISOString()}"
 10\t0\t/booking/feature-manage/my.component.ts

apps/backend/src/services/hotspot.ts

@@ -9,7 +9,6 @@ import { Limits } from '../model/limits';
 
 import { calcCyclomaticComplexity } from '../utils/complexity';
 import { countLinesInFile } from '../utils/count-lines';
-import { Config } from '../model/config';
 
 export type ComplexityMetric = 'McCabe' | 'Length';
 
@@ -126,6 +125,10 @@ async function analyzeLogs(
         continue;
       }
 
+      if (!change.path.endsWith('.ts')) {
+        continue;
+      }
+
       if (!hotspots[change.path]) {
         const complexity = calcComplexity(options, change, criteria);
 

apps/frontend/src/app/features/coupling/coupling.component.ts

@@ -96,6 +96,8 @@ export class CouplingComponent {
   toGraph(result: CouplingResult): Graph {
     result.matrix = this.clearSelfLinks(result.matrix);
 
+    console.log('result', result);
+
     const groupNodes: CouplingNodeDefinition[] = this.groupByFolder()
       ? createGroups(result.dimensions)
       : [];

apps/frontend/src/app/features/coupling/graph.adapter.ts

@@ -71,6 +71,9 @@ export function createNodes(
   for (let i = 0; i < result.dimensions.length; i++) {
     const label = result.dimensions[i];
 
+    const soc = result.sumOfCoupling ? result.sumOfCoupling[i] : -1;
+    const relSoc = soc !== null ? soc / result.fileCount[i] : -1;
+
     const node: CouplingNodeDefinition = {
       data: {
         id: '' + i,
@@ -85,8 +88,8 @@ export function createNodes(
   `
             : `${label}
   <br><br>${result.fileCount[i]} commits
-  <br>Outgoing Deps: ${sumRow(result.matrix, i)}
-  <br>Incoming Deps: ${sumCol(result.matrix, i)}
+  <br>Sum of Coupling (SoC): ${soc}
+  <br>SoC per Commit: ${Math.round(relSoc * 100)}%
   `,
         dimension: label,
       },

apps/frontend/src/app/model/coupling-result.ts

@@ -4,6 +4,7 @@ export interface CouplingResult {
   cohesion: number[];
   matrix: number[][];
   groups: string[];
+  sumOfCoupling: [];
 }
 
 export const initCouplingResult: CouplingResult = {
@@ -12,4 +13,5 @@ export const initCouplingResult: CouplingResult = {
   cohesion: [],
   matrix: [[]],
   groups: [],
+  sumOfCoupling: [],
 };

apps/frontend/src/app/ui/graph/graph.component.ts

@@ -1,6 +1,5 @@
 import {
   Component,
-  effect,
   ElementRef,
   input,
   OnChanges,