Skip to content

fix(endpoint): refactor handleError for promise use #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2015
Merged

fix(endpoint): refactor handleError for promise use #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions endpoint/templates/name.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
var _ = require('lodash');
var <%= classedName %> = require('./<%= name %>.model');

function handleError(res, err) {
return res.status(500).send(err);
function handleError(res, statusCode) {
statusCode = statusCode || 500;
return function(err) {
res.status(statusCode).send(err);
};
}

function responseWithResult(res, statusCode) {
Expand All @@ -19,7 +22,7 @@ function responseWithResult(res, statusCode) {
function handleEntityNotFound(res) {
return function(entity) {
if (!entity) {
res.send(404);
res.status(404).end();
return null;
}
return entity;
Expand All @@ -41,7 +44,7 @@ function removeEntity(res) {
if (entity) {
return entity.removeAsync()
.then(function() {
return res.status(204);
res.status(204).end();
});
}
};
Expand All @@ -50,10 +53,9 @@ function removeEntity(res) {
// Get list of <%= name %>s
exports.index = function(req, res) {<% if (!filters.mongoose) { %>
res.json([]);<% } %><% if (filters.mongoose) { %>
<%= classedName %>.find(function(err, <%= name %>s) {
if (err) { return handleError(res, err); }
return res.status(200).json(<%= name %>s);
});<% } %>
<%= classedName %>.findAsync()
.then(responseWithResult(res))
.catch(handleError(res));<% } %>
};<% if (filters.mongoose) { %>

// Gets a single <%= name %> from the DB.
Expand Down