fix(socketio): fallback for when socket.handshake.address is not provided
#369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you update the commit message scope? Unfortunately Thanks! |
Contributor
Author
|
Fixed; |
meeDamian
changed the title
socket.handshake.address is not providedsocket.handshake.address is not provided
meeDamian
changed the title
socket.handshake.address is not providedsocket.handshake.address is not provided
DaftMonk
added a commit
that referenced
this pull request
Jul 21, 2014
fix(socketio): fallback for when `socket.handshake.address` is not provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some servers (ex.
heroku), propertysocket.handshake.addressisnull.This fix, adds fallback to the
DOMAINset inserver/config/_local.env.js.Also:
DOMAINfor each passport Strategy, andlocalhostwould result in an external redirect.