fix(gen:app:socket): use '' instead null as URL to open ioSocket
#435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With socket.io 1.0.6, when opening ioSocket with null as URL, io() will omit the option object. As a result, `query` and Auth Token will not be sent through handshake.
Contributor
|
Are you referring to this? |
Contributor
Author
|
Nope, I'm referring to https://github.com/Automattic/socket.io-client/blob/master/socket.io.js#L41. This is where the |
Contributor
|
👍 |
DaftMonk
added a commit
that referenced
this pull request
Aug 12, 2014
fix(gen:app:socket): use `''` instead `null` as URL to open ioSocket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With socket.io 1.0.6, when opening ioSocket with null as URL, io() will
omit the option object. As a result,
queryand Auth Token will not besent through handshake.