Refactor selector(s) api #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather then accepting an Array of selector functions accept only a single function that returns an object. This object may specify multiple keys in order to return multiple slices of store state. ref: reduxjs/redux#387
elgerlambert
force-pushed
the
refactor/selector
branch
from
3c0c389 to
bf86140
Compare
Contributor
Author
|
Notice that this PR only has to remove code from connector.js to implement; it simplifies the code, improves performance and increases flexibility since the consumer can define the keys it wants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather then accepting an Array of selector functions accept only a single function
that returns an object. This object may specify multiple keys in order to return
multiple slices of store state.
ref: reduxjs/redux#387