chore(soba): pass linting

Author: nartc

libs/soba/.eslintrc.json

@@ -6,24 +6,51 @@
 			"files": ["*.ts"],
 			"extends": ["plugin:@nx/angular", "plugin:@angular-eslint/template/process-inline-templates"],
 			"rules": {
-				"@angular-eslint/directive-selector": 0,
-				"@angular-eslint/component-selector": 0,
-				"@angular-eslint/component-class-suffix": 0,
-				"@angular-eslint/no-input-rename": 0,
-				"@angular-eslint/no-output-native": 0
+				"@angular-eslint/directive-selector": "off",
+				"@angular-eslint/component-selector": "off",
+        "@angular-eslint/directive-class-suffix": "off",
+				"@angular-eslint/component-class-suffix": "off",
+				"@angular-eslint/no-input-rename": "off",
+				"@angular-eslint/no-output-native": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }]
 			}
 		},
-		{
-			"files": ["*.html"],
-			"extends": ["plugin:@nx/angular-template"],
-			"rules": {}
-		},
-		{
-			"files": ["*.json"],
-			"parser": "jsonc-eslint-parser",
-			"rules": {
-				"@nx/dependency-checks": "error"
-			}
-		}
+    {
+      "files": ["setup-canvas.ts", "*.stories.ts"],
+      "rules": {
+        "@typescript-eslint/ban-types": "off",
+        "@typescript-eslint/no-empty-function": "off"
+      }
+    },
+    {
+      "files": ["*.html"],
+      "extends": ["plugin:@nx/angular-template"],
+      "rules": {}
+    },
+    {
+      "files": ["*.json"],
+      "parser": "jsonc-eslint-parser",
+      "rules": {
+        "@nx/dependency-checks": [
+          "error",
+          {
+            "ignoredDependencies": [
+              "@analogjs/vite-plugin-angular",
+              "@angular/common",
+              "@nx/vite",
+              "@storybook/angular",
+              "angular-three",
+              "hls.js",
+              "meshline",
+              "ngxtension",
+              "tslib",
+              "vite"
+            ]
+          }
+        ]
+      }
+    }
 	]
 }

libs/soba/.storybook/preview.ts

@@ -1,5 +1,5 @@
 import { Preview } from '@storybook/angular';
-// @ts-ignore
+// @ts-expect-error - we can import mdx
 import DocumentationTemplate from './documentation-template.mdx';
 
 export default {

libs/soba/abstractions/src/lib/text.ts

@@ -113,7 +113,7 @@ export class NgtsText {
 
 		afterNextRender(() => {
 			this.autoEffect(() => {
-				const [invalidate, text] = [this.invalidate(), this.text(), this.options()];
+				const [invalidate] = [this.invalidate(), this.text(), this.options()];
 				this.troikaMesh.sync(() => {
 					invalidate();
 					this.synced.emit(this.troikaMesh);

libs/soba/controls/src/lib/scroll-controls.ts

@@ -262,17 +262,17 @@ export class NgtsScrollControls {
 		return this._fixed;
 	}
 
-	range(from: number, distance: number, margin: number = 0): number {
+	range(from: number, distance: number, margin = 0): number {
 		const start = from - margin;
 		const end = start + distance + margin * 2;
 		return this.offset < start ? 0 : this.offset > end ? 1 : (this.offset - start) / (end - start);
 	}
 
-	curve(from: number, distance: number, margin: number = 0): number {
+	curve(from: number, distance: number, margin = 0): number {
 		return Math.sin(this.range(from, distance, margin) * Math.PI);
 	}
 
-	visible(from: number, distance: number, margin: number = 0): boolean {
+	visible(from: number, distance: number, margin = 0): boolean {
 		const start = from - margin;
 		const end = start + distance + margin * 2;
 		return this.offset >= start && this.offset <= end;

libs/soba/materials/src/lib/mesh-transmission-material.ts

@@ -188,7 +188,7 @@ export class NgtsMeshTransmissionMaterial {
 
 			material.time = clock.getElapsedTime();
 			// Render only if the buffer matches the built-in and no transmission sampler is set
-			// @ts-ignore
+			// @ts-expect-error - we know material.buffer is not just undefined | null
 			if (material.buffer === fboMain.texture && !transmissionSampler) {
 				parent = getLocalState(material)?.parent() as Mesh;
 

libs/soba/misc/src/lib/sampler.ts

@@ -204,7 +204,10 @@ export class NgtsSampler {
 
 					this.meshToSample.set(mesh ?? (localState.objects().find((c) => c.type === 'Mesh') as Mesh));
 					this.instancedToSample.set(
-						instances ?? (localState.objects().find((c) => c.hasOwnProperty('instanceMatrix')) as InstancedMesh),
+						instances ??
+							(localState
+								.objects()
+								.find((c) => !!Object.getOwnPropertyDescriptor(c, 'instanceMatrix')) as InstancedMesh),
 					);
 				},
 				{ allowSignalWrites: true },

libs/soba/src/abstractions/grid.stories.ts

@@ -1,6 +1,6 @@
 import { ChangeDetectionStrategy, Component, CUSTOM_ELEMENTS_SCHEMA, input, Signal } from '@angular/core';
 import { Meta } from '@storybook/angular';
-import { NgtArgs } from 'angular-three';
+import { NgtAnyRecord, NgtArgs } from 'angular-three';
 import { NgtsGrid } from 'angular-three-soba/abstractions';
 import { NgtsOrbitControls } from 'angular-three-soba/controls';
 import { injectGLTF } from 'angular-three-soba/loaders';
@@ -11,7 +11,7 @@ import { makeDecorators, makeStoryFunction } from '../setup-canvas';
 
 type SuzanneGLTF = GLTF & {
 	nodes: { Suzanne: Mesh };
-	materials: {};
+	materials: NgtAnyRecord;
 };
 
 @Component({

libs/soba/src/performances/instances.stories.ts

@@ -17,9 +17,9 @@ function randomEuler() {
 	return [Math.random() * Math.PI, Math.random() * Math.PI, Math.random() * Math.PI];
 }
 
-const data = Array.from({ length: 1000 }, (r: number = 10) => ({
+const data = Array.from({ length: 1000 }, (r: number) => ({
 	random: Math.random(),
-	position: randomVector(r),
+	position: randomVector(r ?? 10),
 	rotation: randomEuler(),
 }));
 

libs/soba/staging/src/lib/bounds.ts

@@ -23,20 +23,6 @@ interface ControlsProto {
 	removeEventListener: (event: string, callback: (event: any) => void) => void;
 }
 
-interface OriginT {
-	camPos: Vector3;
-	camRot: Quaternion;
-	camZoom: number;
-}
-
-interface GoalT {
-	camPos: Vector3 | undefined;
-	camRot: Quaternion | undefined;
-	camZoom: number | undefined;
-	camUp: Vector3 | undefined;
-	target: Vector3 | undefined;
-}
-
 enum AnimationState {
 	NONE = 0,
 	START = 1,

libs/soba/staging/src/lib/environment.ts

@@ -123,7 +123,8 @@ export function injectEnvironment(
 ) {
 	return assertInjector(injectEnvironment, injector, () => {
 		const adjustedOptions = computed(() => {
-			let { files, path, preset, extensions, encoding } = options();
+			const { preset, extensions, encoding, ...rest } = options();
+			let { files, path } = rest;
 
 			if (files == null) {
 				files = ['/px.png', '/nx.png', '/py.png', '/ny.png', '/pz.png', '/nz.png'];
@@ -213,7 +214,7 @@ export function injectEnvironment(
 
 			const result = injectLoader(
 				loader,
-				// @ts-expect-error
+				// @ts-expect-error - ensure the files is an array
 				() => {
 					const { files } = adjustedOptions();
 					return Array.isArray(files) ? [files] : files;
@@ -242,7 +243,7 @@ export function injectEnvironment(
 					const { multiFile, extension, isCubeMap } = resultOptions();
 					const { encoding } = adjustedOptions();
 
-					// @ts-expect-error
+					// @ts-expect-error - ensure textureResult is a Texture or CubeTexture
 					let textureResult = (multiFile ? loaderResult[0] : loaderResult) as Texture | CubeTexture;
 
 					if (extension === 'jpg' || extension === 'jpeg' || extension === 'webp') {