fix(core): double check for falsy parent in removeChild

Author: nartc

libs/core/src/lib/renderer/index.ts

@@ -286,6 +286,14 @@ export class NgtRenderer implements Renderer2 {
 				untracked(() => getLocalState(oldChild)?.parent)) as NgtRendererNode;
 		}
 
+		// if parent is still falsy, we don't know what to do with the parent.
+		// we'll just remove the child and destroy it
+		if (!parent) {
+			removeThreeChild(oldChild, undefined, true);
+			this.destroyInternal(oldChild, undefined);
+			return;
+		}
+
 		const pRS = parent.__ngt_renderer__;
 		const cRS = oldChild.__ngt_renderer__;
 
@@ -306,7 +314,7 @@ export class NgtRenderer implements Renderer2 {
 		}
 
 		if (pRS[NgtRendererClassId.type] === 'three' && cRS[NgtRendererClassId.type] === 'three') {
-			removeThreeChild(parent, oldChild, true);
+			removeThreeChild(oldChild, parent, true);
 			this.destroyInternal(oldChild, parent);
 			return;
 		}
@@ -522,13 +530,13 @@ export class NgtRenderer implements Renderer2 {
 		for (const renderChild of rS[NgtRendererClassId.children] || []) {
 			if (renderChild.__ngt_renderer__?.[NgtRendererClassId.type] === 'three' && parent) {
 				if (parent.__ngt_renderer__?.[NgtRendererClassId.type] === 'three') {
-					removeThreeChild(parent, renderChild, true);
+					removeThreeChild(renderChild, parent, true);
 					continue;
 				}
 
 				const closestInstance = getClosestParentWithInstance(parent);
 				if (closestInstance) {
-					removeThreeChild(closestInstance, renderChild, true);
+					removeThreeChild(renderChild, closestInstance, true);
 				}
 			}
 			this.destroyInternal(renderChild, parent);

libs/core/src/lib/renderer/utils.ts

@@ -121,7 +121,7 @@ export function attachThreeChild(parent: NgtInstanceNode, child: NgtInstanceNode
 	invalidateInstance(parent);
 }
 
-export function removeThreeChild(parent: NgtInstanceNode, child: NgtInstanceNode, dispose?: boolean) {
+export function removeThreeChild(child: NgtInstanceNode, parent?: NgtInstanceNode, dispose?: boolean) {
 	const pLS = getLocalState(parent);
 	const cLS = getLocalState(child);
 
@@ -132,12 +132,14 @@ export function removeThreeChild(parent: NgtInstanceNode, child: NgtInstanceNode
 	pLS?.remove(child, 'objects');
 	pLS?.remove(child, 'nonObjects');
 
-	if (cLS?.attach) {
-		detach(parent, child, cLS.attach);
-	} else if (is.object3D(parent) && is.object3D(child)) {
-		parent.remove(child);
-		const store = cLS?.store || pLS?.store;
-		if (store) removeInteractivity(store, child);
+	if (parent) {
+		if (cLS?.attach) {
+			detach(parent, child, cLS.attach);
+		} else if (is.object3D(parent) && is.object3D(child)) {
+			parent.remove(child);
+			const store = cLS?.store || pLS?.store;
+			if (store) removeInteractivity(store, child);
+		}
 	}
 
 	const isPrimitive = cLS?.primitive;
@@ -151,11 +153,13 @@ export function removeThreeChild(parent: NgtInstanceNode, child: NgtInstanceNode
 		queueMicrotask(() => child['dispose']());
 	}
 
-	invalidateInstance(parent);
+	if (parent) {
+		invalidateInstance(parent);
+	}
 }
 
 function removeThreeRecursive(array: NgtInstanceNode[], parent: NgtInstanceNode, dispose: boolean) {
-	if (array) [...array].forEach((child) => removeThreeChild(parent, child, dispose));
+	if (array) [...array].forEach((child) => removeThreeChild(child, parent, dispose));
 }
 
 export function processThreeEvent(