TypeError: undefined is not a function with data-pagination

[micossow]

Angularjs: 1.2.26
Angular-ui: 0.11.2

I created such view:

<table data-pagination="true">
    <thead>
        <tr>
            <th>ID</th>
        </tr>
    </thead>
</table>

Got error:

TypeError: undefined is not a function
    at Object.fn (http://172.28.176.23:8877/app/bower_components/angular-bootstrap/ui-bootstrap-tpls.js:2256:19)
    at Scope.$digest (http://172.28.176.23:8877/app/bower_components/angular/angular.js:12541:29)
    at Scope.$apply (http://172.28.176.23:8877/app/bower_components/angular/angular.js:12806:24)
    at done (http://172.28.176.23:8877/app/bower_components/angular/angular.js:8379:45)
    at completeRequest (http://172.28.176.23:8877/app/bower_components/angular/angular.js:8593:7)
    at XMLHttpRequest.xhr.onreadystatechange (http://172.28.176.23:8877/app/bower_components/angular/angular.js:8532:11) 

Removing data-pagination="true" fixes issue.
I need this directive for compatibility with Bootstrap Table module (http://wenzhixin.net.cn/p/bootstrap-table/docs/index.html)

[chrisirhc]

Could you create a Plunker that reproduces this issue?

Ref: https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md#you-think-youve-found-a-bug

[pkozlowski-opensource]

@chrisirhc I think that this might be coming from the fact that:

• we are not prefixing our directives
• pagination is marked as AE
• angular normalizes directives.

So we are picking up <table data-pagination="true"> as a directive and it throws since there are other missing attributes.

IMO we should close this one as a duplicate of the prefixing issue ... and add those prefixes :-)

[chrisirhc]

That's a good idea, should we put that to 0.13 milestone? Perhaps we could setup the next milestone and start planning a little further ahead and be little more daring about breaking everybody's code heh.

It'll be painful, but we'll have to get over it.

[pkozlowski-opensource]

Yeh, this is a painful but necessary move... We were putting it off for way too long...

One thing we can quickly & safely (or so I hope) is to prefix all the controllers.

[wesleycho]

Closing as per comments - see #3396.