Update modal.js to work with bootstrap 3.3.1

[maxisam]

To work with bootstrap 3.3.1. Ref #2970

[maxisam]

To work with bootstrap 3.3.1. Specifically handle this change

Here is the demo

[chrisirhc]

Thank you!
This also needs an accompanying test. It's also helpful when you're submitting pull requests to refer to the issue you're trying to resolve in the pull request message body. Like this: #2970
So that users will be able to follow where's the latest fix.

[BeMxself]

It doesn't work well, this code get body's scrollHeight, but sometimes body's scrollHeight is not high enough, please check it.

[maxisam]

Interesting. Can you put it in plunk or somewhere so I can check it ? This is the way how original bootstrap modal does the trick. So if there is an issue with this approach, the original one would have the same issue.

[BeMxself]

you can open your demo by IE11 to reproduce this bug.

The bootstrap.js is getting ".modal" Element's scrollHeight, not body's scrollHeight.

[jonathaningram]

If this change mirrors the core BS change, shouldn't it also first set the height to 0?

angularBackgroundDomEl
  .css('height', 0)
  .css('height', body[0].scrollHeight + 'px');

Note: I'm not sure exactly why BS do that, maybe it's to do with reflow or something.

[maxisam]

I think @BeMxself point it out correctly. I should get the modal-window element instead of body. I am thinking about how to achieve it easily.

[maxisam]

here is the demo to walk around this issue. I think a proper way requires a lot of work. I will try if I can make it.