Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Conversation

stevecavanagh
Copy link

Fix for issue: #3098. Register the MainCtrl function in the demo module, not as a global function.

@stevecavanagh
Copy link
Author

Here are some plunks demonstrating that I did indeed fix this issue.
First, my initial commit (which resolved the MainCtrl error, but left the Download and Create Build broken): http://plnkr.co/edit/AsPUFjhhzhLIqFKKHPf2?p=preview
My second commit which fixed the Download and Create Build: http://plnkr.co/edit/O7Gm2HMdaRqhYK2ObFqh?p=preview
A final plunker to demonstrate that changes also work with current supported Angular JS version 1.2.16: http://plnkr.co/edit/KDqZhgYLaEpVKdi2pbDt?p=preview

@wesleycho
Copy link
Contributor

Thanks for this, although I opted for #3191 for its simplicity in comparison.

@wesleycho wesleycho closed this Mar 16, 2015
@stevecavanagh
Copy link
Author

Understood, thanks for moving things forward with 1.3!

---- Wesley Cho wrote ----

Thanks for this, although I opted for #3191 for its simplicity in comparison.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants