Skip to content

include header,footer,scrollbar when calculating initial grid height #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2014
Merged

include header,footer,scrollbar when calculating initial grid height #2008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/js/core/directives/ui-grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,12 @@ angular.module('ui.grid').directive('uiGrid',
// If the grid isn't tall enough to fit a single row, it's kind of useless. Resize it to fit a minimum number of rows
if (grid.gridHeight < grid.options.rowHeight) {
// Figure out the new height
var newHeight = grid.options.minRowsToShow * grid.options.rowHeight;
var contentHeight = grid.options.minRowsToShow * grid.options.rowHeight;
var headerHeight = grid.options.hideHeader ? 0 : grid.options.headerRowHeight;
var footerHeight = grid.options.showFooter ? grid.options.footerRowHeight : 0;
var scrollbarHeight = grid.options.enableScrollbars ? gridUtil.getScrollbarWidth() : 0;

var newHeight = headerHeight + contentHeight + footerHeight + scrollbarHeight;

$elm.css('height', newHeight + 'px');

Expand Down