Resolved dependencies are not inherited down to child states across different modules

[meenie]

As per the documentation, ui-router children states should inherit parent resolved dependencies but it seems to not work across modules.

An example of what I mean can be found here: http://plnkr.co/edit/gRAmbUQOVB0pmg5Rch4n?p=preview

I've pulled the latest master of ui-router and did a grunt to build the very latest version and included it in the plnkr.

[dlukez]

When resolve is outside the views block it seems to work:

http://plnkr.co/edit/XJBJXNXCrEx9RG8C706s?p=preview

[meenie]

When resolve is outside the views block it seems to work:

Neat, so this shouldn't be too hard to fix? :)

[timkindberg]

I feel like this is a duplicate but can't find the bug that I'm thinking its a dup of.

[timkindberg]

Neat, so this shouldn't be too hard to fix? :)

@meenie Its not high on the priority list because you can get it to work by moving the resolve outside of the view block. If you want to fix it and submit a PR we'd give you a big digital high five!

[dlukez]

Do you guys reckon it needs a fix? What would you expect to happen when you declare a resolve inside a view? That the controller for a view of a child state, that is a DOM descendant of the parent state's view, is injected with the resolved thing? Seems unnecessarily complicated! I think it makes more sense if a resolve inside a view is just specifically for that view... And resolves at the state level get passed to child states.

[nateabele]

I'm really confused as to where this idea keeps coming from that resolves can be placed within view definitions. As far as I can tell, there's no reference to this in the documentation, and the fact that it works (if, in fact, it works) is completely incidental and unintended. The resolve key goes in the state definition. As noted by @dlukez, when used correctly, it works fine.

[nateabele]

@dlukez To sort of answer your question, resolve inheritance only cascades parent-to-child via states. Nothing related to views is inherited in any way, except with respect to scope inheritance when one view is nested inside another, vis-á-vis https://github.com/angular-ui/ui-router/wiki/Nested-States-%26-Nested-Views#scope-inheritance-by-view-hierarchy-only. Hope that helps.

[dlukez]

@nateabele Yeah that clarifies things, thanks!

[meenie]

@nateabele - I've been using ui-router for quite awhile now and I swear I read in the documentation at one time that the resolve key can be placed under a view definition or a state definition. This is the way I've been doing it since day one. Now that I know that it shouldn't be the case, I will now go through update all of my resolves to match the correct syntax.

Since it does work under the view definition, I guess there is some old code in ui-router that should be removed and placed with an exception telling the developer not to do that.

Sorry to waste your time.

[nateabele]

I've been using ui-router for quite awhile now and I swear I read in the documentation at one time that the resolve key can be placed under a view definition or a state definition.

@meenie Weird. Yeah, maybe that was the case, because this is definitely not the first time (probably not even the second) that this has come up. Anyway, no worries, sorry for the confusion.

[laurelnaiad]

The docs for decorator say you can define resolve within the views object. Is that untrue?

https://github.com/angular-ui/ui-router/wiki/Quick-Reference#spdecoratorname--decorator

[laurelnaiad]

Shouldnt resolve be supported everywhere where you can declarea controller? If the controller and template that show up in the state are just shortcuts to the unnamed view then wouldn't it make sense to support resolve in views?

[nateabele]

@stu-salsbury Ah, yeah, good find, thanks. I've just rewritten the page to remove any references to resolve being in view configurations. @meenie Again, sorry for the confusion. :-) My bad.

@stu-salsbury As far as resolves being in view configurations, it really doesn't make any sense. The resolves are tied to the state, not to the controllers. A resolve you define in a state can be injected into any controller defined in that state.

[timkindberg]

@nateabele so yeah... pretty sure I've been saying this just about... oh I don't know... everywhere. I'll have to go fix all the various locations I've said it. SORRY dude!