fix(@ngtools/webpack): only emit import default helper when needed #17611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
import-default-helper
branch
from
8231455 to
5e70ec4
Compare
Previously, the import default TypeScript helper was emitted for every file when in JIT mode. This was unused code in the majority of cases. The helper is now emitted only when needed. For this package that would be when an Angular component decorator's resource URL properties are adjusted to support JIT execution with Webpack.
clydin
force-pushed
the
import-default-helper
branch
from
5e70ec4 to
7d212d2
Compare
Collaborator
|
Also merged to |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the import default TypeScript helper was emitted for every file when in JIT mode. This was unused code in the majority of cases. The helper is now emitted only when needed. For this package that would be when an Angular component decorator's resource URL properties are adjusted to support JIT execution with Webpack.