fix(@schematics/angular): improve comment preservation in jasmine-to-vitest #31483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the test suite for the `jasmine-to-vitest` schematic by centralizing the duplicated `expectTransformation` helper function into a single `test-helpers.ts` file. This change improves the long-term maintainability of the test suite by: - Reducing code duplication across multiple spec files. - Creating a single source of truth for the core test logic, making future updates easier. - Improving the overall structure and readability of the tests.
clydin
force-pushed
the
refactor/jasmine-vitest-8
branch
from
8289333 to
a9f1817
Compare
…vitest This commit improves the preservation of comments during the `jasmine-to-vitest` transformation. Specifically, it fixes an issue where multi-line comments between chained spy calls were being discarded. The transformer has been updated to use a less destructive AST modification pattern, which successfully preserves this trivia. Additionally, a previously failing test case for this scenario has been re-enabled and is now passing.
clydin
force-pushed
the
refactor/jasmine-vitest-8
branch
from
a9f1817 to
2027b1d
Compare
clydin
added
the
action: review
…vior The arrays of transformer functions have been reorganized into commented, logical stages. This makes the implicit, top-down execution order explicit, which is critical for the correctness of context-sensitive transformations.
jkrems
approved these changes
Oct 15, 2025
jkrems
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the preservation of comments during the
jasmine-to-vitesttransformation.Specifically, it fixes an issue where multi-line comments between chained spy calls were being discarded. The transformer has been updated to use a less destructive AST modification pattern, which successfully preserves this trivia.
Additionally, a previously failing test case for this scenario has been re-enabled and is now passing.