New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): extend tslint:recommended #13213

Merged
merged 1 commit into from Dec 26, 2018

Conversation

Projects
None yet
5 participants
@cexbrayat
Copy link
Contributor

cexbrayat commented Dec 18, 2018

Updates the tslint.json file to extend to the tslint:recommended set.
Removes the rules that have the same value as the recommended one and explicitely deactivates some rules that are activated in the recommended set, but were not in ours.

Fixes #6179

cc @mgechev this is to start the discussion, feedback welcome

@googlebot googlebot added the cla: yes label Dec 18, 2018

@mgechev mgechev requested review from filipesilva and hansl Dec 18, 2018

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

From my end this LGTM.

Waiting for @mgechev to confirm.

"check-space"
],
"curly": true,
"adjacent-overload-signatures": false,

This comment has been minimized.

@mgechev

mgechev Dec 20, 2018

Member

Looks like in the current CLI and tslint this has value true, lmk if I'm wrong.

This comment has been minimized.

@cexbrayat

cexbrayat Dec 20, 2018

Author Contributor

Hmm, I don't think it is present in the current tslint.json, so I guess it's not activated (unless I'm missing something?).

@mgechev

This comment has been minimized.

Copy link
Member

mgechev commented Dec 20, 2018

object-literal-key-quotes should be also disabled.

@mgechev
Copy link
Member

mgechev left a comment

@cexbrayat left one comment. Otherwise, LGTM

@mgechev
Copy link
Member

mgechev left a comment

object-literal-key-quotes seems the only config to fix.

feat(@schematics/angular): extend tslint:recommended
Updates the `tslint.json` file to extend to the `tslint:recommended` set.
Removes the rules that have the same value as the recommended one and explicitely deactivates some rules that are activated in the recommended set, but were not in ours.

@cexbrayat cexbrayat force-pushed the cexbrayat:feat/extend-tslint-recommended branch from 23945da to 6d72396 Dec 21, 2018

@cexbrayat

This comment has been minimized.

Copy link
Contributor Author

cexbrayat commented Dec 21, 2018

@mgechev good catch: I added object-literal-key-quotes: false 👍

@hansl hansl merged commit 2f262bb into angular:master Dec 26, 2018

12 of 13 checks passed

ci/angular: merge status 3 pending code reviews
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-node-8 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@cexbrayat cexbrayat deleted the cexbrayat:feat/extend-tslint-recommended branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment