ci: add windows buildkite

[filipesilva]

Related to angular/angular#27205.

[clydin]

Nice job putting this together
This looks like it takes roughly 54 minutes (about the same as AppVeyor which is an excellent start). CircleCI runs the full E2E test suite in ~50 minutes. Is there anyway to improve the performance here?

[clydin]

is --disable-gpu still needed? This was originally due to a bug with windows support.

[filipesilva]

Might not be, no. Will remove and see if it's ok.

[clydin]

Hard coding the version in multiple places should be avoided if possible. Would it be possible to centralize the chrome and driver version information?

[filipesilva]

Hmm no ergonomic solution comes to mind. Storing it on a env var would need the var to be set, and a cross platform solution.

Storing it on a node module would require a roundabout way of calling webdriver-update from the node bin.

Right now it's in 2 places, which is better than before, but still would be better to be in a single place. Although to be fair it's on two places because each of them happen to install a certain version of puppeteer, and these two things happen to match (e.g. one can imagine one of these places using a different puppeteer/webdriver combo).

Did you have an approach in mind?

[filipesilva]

@clydin performance wise, caching and sharding would both help right now. Caching would speed up the initial setup. Sharding would make each individual shard take less time to complete.

I have explored caching in angular/angular#27990, but haven't explored sharding. I expect we'd do something similar as today in CircleCI.

Long term further Bazel integration should make sharding moot though. Under an ideal Bazel setup the remote cache/execution would manage cache. Initial cache for node_modules and Bazel artifacts would still be of help.

[clydin]

Something to note though is that circleCI (on Linux) takes a total of ~48 minutes to run the full suite of 187 tests and that is with a full rebuild and setup of the E2E infrastructure four times. Whereas this and appveyor are only running 87 tests.
Is this just a windows file system access performance issue (or other windows specific concern)?

[filipesilva]

I'm not aware of the specific cause of windows taking longer overall for our e2e suite. It's worth looking into further. FS is much slower on windows, yes, but that can't be the full story.

[filipesilva]

We'll also need to ensure there's a hard timeout in the future. In https://buildkite.com/angular/cli/builds/26#d9a71d0c-0863-4bb5-8ab2-ffb07d89a1a6 npm install was seen taken almost two days before I manually cancelled it.

[kyliau]

Filipe on Slack: The snapshot_publish circleci check shouldn't be running, but I think it runs because I made the branch directly on angular-cli instead of on a fork.

Merging this despite ci/circleci: snapshot_publish failing.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}