Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 25, 2020

feat(@angular-devkit/build-angular): extract i18n messages from libraries

Closes #18871

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Sep 25, 2020
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! SImple and neat solution.

@kyubisation
Copy link
Contributor

Thank you very much for your work on this issue. 👍
To avoid any misunderstandings; Our primary use case from #18871 is extraction of i18n tokens from libraries in node_modules and not from "local" libraries.
Due to my limited understanding of the extractor, I cannot discern if this would be handled with this solution.

@alan-agius4
Copy link
Collaborator Author

To avoid any misunderstandings; Our primary use case from #18871 is extraction of i18n tokens from libraries in node_modules and not from "local" libraries.
Due to my limited understanding of the extractor, I cannot discern if this would be handled with this solution.

This works for both local and node_modules libraries.

@kyubisation
Copy link
Contributor

Thank you very much for the clarification and again for your work on this! ❤️

@alan-agius4 alan-agius4 linked an issue Sep 25, 2020 that may be closed by this pull request
15 tasks
@alan-agius4 alan-agius4 removed a link to an issue Sep 25, 2020
15 tasks
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 25, 2020
@alan-agius4 alan-agius4 merged commit 64f340d into angular:master Sep 25, 2020
@alan-agius4 alan-agius4 deleted the extract-messages-libs branch September 25, 2020 15:59
@santam85
Copy link

@petebacondarwin @alan-agius4 are you planning to merge this for a 10.1.x patch too?

@alan-agius4
Copy link
Collaborator Author

@santam85, No this feature will not be back ported to v10.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ng xi18n --ivy does not extract i18n tokens from libraries
6 participants