tutorial/toh-pt6.md の翻訳 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lacolaco merged 2 commits into angular:master from chloe463:translate/toh-pt6

Nov 16, 2017

Contributor

chloe463 commented Nov 15, 2017

tutorial/top-ph6.mdの翻訳をしたので、レビューお願いしますm(_ _)m

issue: #58


          translate: tutorial/toh-pt6

5598ce8

googlebot commented Nov 15, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Contributor Author

chloe463 commented Nov 15, 2017

I signed it!

googlebot commented Nov 15, 2017

CLAs look good, thanks!

lacolaco added pr_state: Wait for review type: translation labels

lacolaco self-assigned this

lacolaco requested changes

View reviewed changes

Collaborator

lacolaco left a comment

レビューしました。いくつかの部分で修正をお願いします

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              * ユーザーは名前でヒーロー情報を検索できます。

              When you're done with this page, the app should look like this <live-example></live-example>.

              このページを終えたとき、このアプリは次のようになります。<live-example></lib-example>

Collaborator

lacolaco Nov 15, 2017

ミスですか？

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              * open the root `AppModule`, 

              * import the `HttpClientModule` symbol from `@angular/common/http`,

              * add it to the `@NgModule.imports` array.

              * ルート`AppModule`を開く

Collaborator

lacolaco Nov 15, 2017

ルートの に修正していただけますか？

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              * `@NgModule.imports`の配列に`HttpClientModule`を追加

              ## Simulate a data server

              ## データサーバーをシミュレート

Collaborator

lacolaco Nov 15, 2017

シミュレートする に修正お願いします

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              </code-example>

              ### Get heroes with _HttpClient_

              ### _HttpClient_を使ってヒーローを取得

Collaborator

lacolaco Nov 15, 2017

取得する に修正お願いします

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              The `HeroService` methods will **tap** into the flow of observable values

              and send a message (via `log()`) to the message area at the bottom of the page.

              `HeroService`のメソットはObservableな値の流れに入り込んで、(`log()`を通して)ページ下部にメッセージを送信します。

Collaborator

lacolaco Nov 15, 2017

メソッド

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              `AsyncPipe`は自動的に`Observable`をsubscribeするので、コンポーネントクラスで何もする必要はありません。

              ### Fix the _HeroSearchComponent_ class

              ### _HeroSearchComponent_クラスの修正

Collaborator

lacolaco Nov 16, 2017

を修正する

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              <code-example path="toh-pt6/src/app/hero-search/hero-search.component.ts" title="src/app/hero-search/hero-search.component.ts"></code-example>

              Notice the declaration of `heroes$` as an `Observable`

              `heroes$`の宣言が`Observable`であることに注意

Collaborator

lacolaco Nov 16, 2017

注意しましょう

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              <code-example path="toh-pt6/src/app/hero.service.ts" region="deleteHero" title="src/app/hero.service.ts (削除)"></code-example>

              Note that

              下記に注目

Collaborator

lacolaco Nov 16, 2017

注目しましょう

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              {@a search-pipe}

              ### Chaining RxJS operators

              ### RxJSオペレーターのチェーン

Collaborator

lacolaco Nov 16, 2017

チェーン -> 連結

aio-ja/content/tutorial/toh-pt6.md Outdated

    
              It cancels and discards previous search observables, returning only the latest search service observable.

              * `switchMap()`は`debounce`と`distinctUntilChanged`を通り抜けた各検索語について検索サービスを呼び出します。

              これは破棄された直前のobservableらをキャンセルして、最新の検索サービスのobservableのみを返却します。

Collaborator

lacolaco Nov 16, 2017

これはそれまでの検索のobservableをキャンセルし、最新の検索サービスのobservableだけを返します

lacolaco added pr_state: Need to fix and removed pr_state: Wait for review labels


          fix: レビュー内容の反映

b9c838a

Contributor Author

chloe463 commented Nov 16, 2017

@lacolaco 修正いたしました！

lacolaco approved these changes

View reviewed changes

Collaborator

lacolaco commented Nov 16, 2017

修正ありがとうございました！

lacolaco added pr_state: Ready to Merge and removed pr_state: Need to fix labels

lacolaco merged commit f1b5a46 into angular:master

chloe463 deleted the translate/toh-pt6 branch

February 28, 2018 12:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr_state: Ready to Merge type: translation