Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Plunkr examples are not working #3395

@mohessaid

Description

@mohessaid

Expected Behavior

When I run a live example from the docs I should be able to see the example running in plunkr without any intervention.

Actual Behavior

All the examples using external template and style files like in the routing or http tutorials are not working in plunkr due to an error in the construction of these files's urls.

Suggestions:

To make these examples work in plunkr I updated the systemjs loader by correcting the substring replacing line to keep the letter 'a' in 'app' like this:

urls.push(`'${basePath.substr(1)}${match[2].substr(1)}'`);`

becomes :

urls.push(`'${basePath}${match[2].substr(1)}'`);`

or

urls.push(`'${basePath.substr(0)}${match[2].substr(1)}'`);

This will work only on the preview link not in the embedded one.
To fix the embedded link problem we just need to add this if statement :

if (url.href.indexOf('preview') != -1){
    basePathParts.shift();
 }

inside this one :

if (url.href.indexOf('plnkr') != -1) {
    basePathParts.shift();
    basePathParts.shift();
 }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions