refactor(core): export profile event as enum and move profile_types.ts and framework to shared devtools folder

tsc036 · tsc036 · commit a1bb6846c7c4 · 2025-11-12T11:13:33.000-08:00
move framework enum and profile_types to a shared folder so it can be used by wiz
diff --git a/goldens/public-api/core/global_utils.api.md b/goldens/public-api/core/global_utils.api.md
@@ -4,6 +4,8 @@
 
 ```ts
 
+import { ɵFramework } from '@angular/core';
+
 // @public
 export function applyChanges(component: {}): void;
 
diff --git a/packages/core/BUILD.bazel b/packages/core/BUILD.bazel
@@ -36,10 +36,10 @@ ng_project(
         "//:node_modules/zone.js",
         "//packages:goog_types",
         "//packages/core/primitives/defer:triggers",
+        "//packages/core/primitives/devtools",
         "//packages/core/primitives/di",
         "//packages/core/primitives/dom-navigation",
         "//packages/core/primitives/event-dispatch",
-        "//packages/core/primitives/profiler",
         "//packages/core/primitives/signals",
         "//packages/core/src/compiler",
         "//packages/core/src/di/interface",
diff --git a/packages/core/primitives/devtools/BUILD.bazel b/packages/core/primitives/devtools/BUILD.bazel
@@ -6,7 +6,7 @@ package(default_visibility = [
 ])
 
 ts_project(
-    name = "profiler",
+    name = "devtools",
     srcs = glob(
         [
             "**/*.ts",
diff --git a/packages/core/primitives/devtools/README.md b/packages/core/primitives/devtools/README.md
@@ -0,0 +1,3 @@
+# Angular Profiler Types
+
+This directory contains interfaces and enums related to the [Angular Devtools](https://angular.dev/tools/devtools). Use these interfaces and enums if you need to hook into Angular Devtools.
diff --git a/packages/core/primitives/devtools/index.ts b/packages/core/primitives/devtools/index.ts
@@ -0,0 +1,10 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
+export {ProfilerEvent, type Profiler} from './src/profiler_types';
+export {Framework} from './src/framework';
diff --git a/packages/core/primitives/devtools/src/framework.ts b/packages/core/primitives/devtools/src/framework.ts
@@ -0,0 +1,14 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
+/** The framework used to author a particular application or component. */
+export enum Framework {
+  Angular = 'angular',
+  ACX = 'acx',
+  Wiz = 'wiz',
+}
diff --git a/packages/core/primitives/devtools/src/profiler_types.ts b/packages/core/primitives/devtools/src/profiler_types.ts
@@ -1,4 +1,4 @@
-/*!
+/**
  * @license
  * Copyright Google LLC All Rights Reserved.
  *
@@ -14,7 +14,7 @@
  * Profiler events is an enum used by the profiler to distinguish between different calls of user
  * code invoked throughout the application lifecycle.
  */
-export const enum ProfilerEvent {
+export enum ProfilerEvent {
   /**
    * Corresponds to the point in time before the runtime has called the template function of a
    * component with `RenderFlags.Create`.
diff --git a/packages/core/primitives/profiler/README.md b/packages/core/primitives/profiler/README.md
diff --git a/packages/core/src/application/application_ref.ts b/packages/core/src/application/application_ref.ts
@@ -45,7 +45,7 @@ import {TESTABILITY} from '../testability/testability';
 import {NgZone} from '../zone/ng_zone';
 
 import {profiler} from '../render3/profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {EffectScheduler} from '../render3/reactivity/root_effect_scheduler';
 import {isReactiveLViewConsumer} from '../render3/reactive_lview_consumer';
 import {ApplicationInitStatus} from './application_init';
diff --git a/packages/core/src/application/create_application.ts b/packages/core/src/application/create_application.ts
@@ -17,7 +17,7 @@ import {ApplicationRef} from './application_ref';
 import {provideZonelessChangeDetectionInternal} from '../change_detection/scheduling/zoneless_scheduling_impl';
 import {bootstrap} from '../platform/bootstrap';
 import {profiler} from '../render3/profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {errorHandlerEnvironmentInitializer} from '../error_handler';
 import {RuntimeError, RuntimeErrorCode} from '../errors';
 import {PlatformRef} from '../platform/platform_ref';
diff --git a/packages/core/src/core_render3_private_export.ts b/packages/core/src/core_render3_private_export.ts
@@ -62,7 +62,6 @@ export {
   ɵDeferBlockDependencyInterceptor,
   ɵDEFER_BLOCK_DEPENDENCY_INTERCEPTOR,
   ɵDEFER_BLOCK_CONFIG,
-  Framework as ɵFramework,
   BaseDirectiveDebugMetadata as ɵBaseDirectiveDebugMetadata,
   AngularDirectiveDebugMetadata as ɵAngularDirectiveDebugMetadata,
   AngularComponentDebugMetadata as ɵAngularComponentDebugMetadata,
@@ -276,7 +275,8 @@ export {isNgModule as ɵisNgModule} from './render3/jit/util';
 export {
   Profiler as ɵProfiler,
   ProfilerEvent as ɵProfilerEvent,
-} from '../primitives/profiler/src/profiler_types';
+  Framework as ɵFramework,
+} from '../primitives/devtools';
 export {
   FrameworkAgnosticGlobalUtils as ɵFrameworkAgnosticGlobalUtils,
   GlobalDevModeUtils as ɵGlobalDevModeUtils,
diff --git a/packages/core/src/defer/rendering.ts b/packages/core/src/defer/rendering.ts
@@ -52,7 +52,7 @@ import {
   getTemplateIndexForState,
 } from './utils';
 import {profiler} from '../render3/profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {addLViewToLContainer, removeLViewFromLContainer} from '../render3/view/container';
 
 /**
diff --git a/packages/core/src/render3/after_render/manager.ts b/packages/core/src/render3/after_render/manager.ts
@@ -18,7 +18,7 @@ import {type DestroyRef} from '../../linker/destroy_ref';
 import {NgZone} from '../../zone';
 import {AFTER_RENDER_SEQUENCES_TO_ADD, FLAGS, LView, LViewFlags} from '../interfaces/view';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../../primitives/devtools';
 import {markAncestorsForTraversal} from '../util/view_utils';
 import {AfterRenderPhase, AfterRenderRef} from './api';
 
diff --git a/packages/core/src/render3/component_ref.ts b/packages/core/src/render3/component_ref.ts
@@ -72,7 +72,7 @@ import {
   stringifyCSSSelectorList,
 } from './node_selector_matcher';
 import {profiler} from './profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {executeContentQueries} from './queries/query_execution';
 import {enterView, leaveView} from './state';
 import {debugStringifyTypeForError, stringifyForError} from './util/stringify_utils';
diff --git a/packages/core/src/render3/debug/chrome_dev_tools_performance.ts b/packages/core/src/render3/debug/chrome_dev_tools_performance.ts
@@ -10,7 +10,7 @@ import {isTypeProvider} from '../../di/provider_collection';
 import {assertDefined, assertEqual} from '../../util/assert';
 import {performanceMarkFeature} from '../../util/performance';
 import {setProfiler} from '../profiler';
-import {Profiler, ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
+import {Profiler, ProfilerEvent} from '../../../primitives/devtools';
 import {stringifyForError} from '../util/stringify_utils';
 import {
   InjectorProfiler,
diff --git a/packages/core/src/render3/hooks.ts b/packages/core/src/render3/hooks.ts
@@ -35,7 +35,7 @@ import {
   TView,
 } from './interfaces/view';
 import {profiler} from './profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {isInCheckNoChangesMode} from './state';
 
 /**
diff --git a/packages/core/src/render3/index.ts b/packages/core/src/render3/index.ts
@@ -30,7 +30,6 @@ import {
 } from './interfaces/public_definitions';
 import {ɵɵsetComponentScope, ɵɵsetNgModuleScope} from './scope';
 import {
-  Framework,
   BaseDirectiveDebugMetadata,
   AngularDirectiveDebugMetadata,
   AngularComponentDebugMetadata,
@@ -215,7 +214,6 @@ export {
   ComponentDef,
   ComponentTemplate,
   ComponentType,
-  Framework,
   BaseDirectiveDebugMetadata,
   AngularDirectiveDebugMetadata,
   AngularComponentDebugMetadata,
diff --git a/packages/core/src/render3/instructions/change_detection.ts b/packages/core/src/render3/instructions/change_detection.ts
@@ -67,7 +67,7 @@ import {
 
 import {isDestroyed} from '../interfaces/type_checks';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../../primitives/devtools';
 import {executeViewQueryFn, refreshContentQueries} from '../queries/query_execution';
 import {runEffectsInView} from '../reactivity/view_effect_runner';
 import {executeTemplate} from './shared';
diff --git a/packages/core/src/render3/instructions/render.ts b/packages/core/src/render3/instructions/render.ts
@@ -22,7 +22,7 @@ import {
   TView,
 } from '../interfaces/view';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../../primitives/devtools';
 import {executeViewQueryFn, refreshContentQueries} from '../queries/query_execution';
 import {enterView, leaveView} from '../state';
 import {getComponentLViewByIndex, isCreationMode} from '../util/view_utils';
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -57,7 +57,7 @@ import {
 import {assertTNodeType} from '../node_assert';
 import {isNodeMatchingSelectorList} from '../node_selector_matcher';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../../primitives/devtools';
 import {
   getCurrentDirectiveIndex,
   getCurrentTNode,
diff --git a/packages/core/src/render3/node_manipulation.ts b/packages/core/src/render3/node_manipulation.ts
@@ -79,7 +79,7 @@ import {
 } from './interfaces/view';
 import {assertTNodeType} from './node_assert';
 import {profiler} from './profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {getLViewParent, getNativeByTNode, unwrapRNode} from './util/view_utils';
 import {allLeavingAnimations} from '../animation/longest_animation';
 import {Injector} from '../di';
diff --git a/packages/core/src/render3/profiler.ts b/packages/core/src/render3/profiler.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {type Profiler} from '../../primitives/profiler/src/profiler_types';
+import {type Profiler} from '../../primitives/devtools';
 
 const profilerCallbacks: Profiler[] = [];
 
diff --git a/packages/core/src/render3/util/discovery_utils.ts b/packages/core/src/render3/util/discovery_utils.ts
@@ -26,6 +26,7 @@ import {CLEANUP, CONTEXT, LView, TVIEW, TViewType} from '../interfaces/view';
 
 import {getRootContext} from './view_traversal_utils';
 import {getLViewParent, unwrapRNode} from './view_utils';
+import {ɵFramework as Framework} from '@angular/core';
 
 /**
  * Retrieves the component instance associated with a given DOM element.
@@ -224,13 +225,6 @@ export function getDirectives(node: Node): {}[] {
   return context.directives === null ? [] : [...context.directives];
 }
 
-/** The framework used to author a particular application or component. */
-export enum Framework {
-  Angular = 'angular',
-  ACX = 'acx',
-  Wiz = 'wiz',
-}
-
 /** Metadata common to directives from all frameworks.  */
 export interface BaseDirectiveDebugMetadata {
   name?: string;
diff --git a/packages/core/src/render3/view/listeners.ts b/packages/core/src/render3/view/listeners.ts
@@ -20,7 +20,7 @@ import {
   unwrapRNode,
 } from '../util/view_utils';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../../primitives/devtools';
 import {markViewDirty} from '../instructions/mark_view_dirty';
 import type {RElement} from '../interfaces/renderer_dom';
 import type {GlobalTargetResolver, Renderer} from '../interfaces/renderer';
diff --git a/packages/core/test/acceptance/BUILD.bazel b/packages/core/test/acceptance/BUILD.bazel
@@ -24,7 +24,7 @@ ts_project(
         "//packages/common/locales",
         "//packages/compiler",
         "//packages/core",
-        "//packages/core/primitives/profiler",
+        "//packages/core/primitives/devtools",
         "//packages/core/primitives/signals",
         "//packages/core/src/di/interface",
         "//packages/core/src/util",
diff --git a/packages/core/test/acceptance/profiler_spec.ts b/packages/core/test/acceptance/profiler_spec.ts
@@ -7,7 +7,7 @@
  */
 
 import {setProfiler, profiler} from '../../src/render3/profiler';
-import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
+import {ProfilerEvent} from '../../primitives/devtools';
 import {TestBed} from '../../testing';
 
 import {
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -201,6 +201,7 @@
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
       "PendingTasksInternal",
+      "ProfilerEvent",
       "QUERIES",
       "QUEUED_CLASSNAME",
       "QUEUED_SELECTOR",
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -201,6 +201,7 @@
       "PRESERVE_HOST_CONTENT_DEFAULT",
       "PendingTasks",
       "PendingTasksInternal",
+      "ProfilerEvent",
       "QUERIES",
       "R3Injector",
       "REACTIVE_LVIEW_CONSUMER_NODE",
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -205,6 +205,7 @@
       "PendingTasksInternal",
       "PlatformRef",
       "PristineChangeEvent",
+      "ProfilerEvent",
       "QUERIES",
       "R3Injector",
       "R3ViewContainerRef",
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -201,6 +201,7 @@
       "PendingTasksInternal",
       "PlatformRef",
       "PristineChangeEvent",
+      "ProfilerEvent",
       "QUERIES",
       "R3Injector",
       "R3ViewContainerRef",
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -177,6 +177,7 @@
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
       "PendingTasksInternal",
+      "ProfilerEvent",
       "QUERIES",
       "R3Injector",
       "REACTIVE_LVIEW_CONSUMER_NODE",
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -218,6 +218,7 @@
       "PendingTasksInternal",
       "PlatformLocation",
       "Position",
+      "ProfilerEvent",
       "QUERIES",
       "QUERY_PARAM_RE",
       "QUERY_PARAM_VALUE_RE",
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -148,6 +148,7 @@
       "PRESERVE_HOST_CONTENT",
       "PRESERVE_HOST_CONTENT_DEFAULT",
       "PendingTasksInternal",
+      "ProfilerEvent",
       "QUERIES",
       "R3Injector",
       "REACTIVE_LVIEW_CONSUMER_NODE",

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ package(default_visibility = [`
`6`	`6`	`])`
`7`	`7`
`8`	`8`	`ts_project(`
`9`		`- name = "profiler",`
	`9`	`+ name = "devtools",`
`10`	`10`	`srcs = glob(`
`11`	`11`	`[`
`12`	`12`	`"*/.ts",`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# Angular Profiler Types`
	`2`	`+`
	`3`	`+This directory contains interfaces and enums related to the [Angular Devtools](https://angular.dev/tools/devtools). Use these interfaces and enums if you need to hook into Angular Devtools.`