Router: Query params are removed when using preserveQueryParams

[brandonroberts]

I'm submitting a ... (check one with "x")

[] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
On a routerLink, if queryParams and preserveQueryParams are used together, the query parameters are not adding to the routerLink.

Expected behavior

Query params are still added to the href even if preserveQueryParams is set.

Minimal reproduction of the problem with instructions

https://plnkr.co/edit/CF3LxPo2XXWYdb40vDwb?p=preview

Run plunker
Note the two links
The first link has no preserveQueryParams set, and hovering over the link shows a query string of ?filter=true
The second link has preserveQueryParams set, and hovering over the link shows no query params.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

• Angular version: 2.0.X

Angular 2.4.x

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

• Language: [all | TypeScript X.X | ES6/7 | ES5]

• Node (for AoT issues): node --version =

cc @DeborahK

[vicb]

The logic is: preserveQueryParams ? this.currentUrlTree.queryParams : queryParams; which makes sense.

Seems like you want a new feature where you could merge current & new params, right ?

[brandonroberts]

Yes, that would be more beneficial

[dejour]

seems i can work with this one.

[dmitrybabiy]

the same issue with skipLocationChange. Query params are removed when i use it or preserveQueryParams