Skip to content

docs(router): Change CanDeactivate to CanLoad#16237

Merged
jasonaden merged 1 commit intoangular:masterfrom
aaronhoffman:router-canload-doc-fix
May 10, 2017
Merged

docs(router): Change CanDeactivate to CanLoad#16237
jasonaden merged 1 commit intoangular:masterfrom
aaronhoffman:router-canload-doc-fix

Conversation

@aaronhoffman
Copy link
Copy Markdown
Contributor

fix mistake in docs, CanDeactivate should be CanLoad

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x ] Other... Please describe:   Documentation Fix

What is the current behavior? (You can also link to an open issue here)
Docs contain CanDeactivate where they should contain CanLoad.

What is the new behavior?
Docs contain CanLoad.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

fix mistake in docs. CanDeactivate should be CanLoad
@aaronhoffman aaronhoffman force-pushed the router-canload-doc-fix branch from e0db1fa to d5ff1c1 Compare April 21, 2017 14:33
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@jasonaden jasonaden self-requested a review May 10, 2017 21:52
@jasonaden
Copy link
Copy Markdown
Contributor

LGTM

@jasonaden jasonaden added the action: merge The PR is ready for merge by the caretaker label May 10, 2017
@jasonaden jasonaden merged commit d28a3f7 into angular:master May 10, 2017
jasonaden pushed a commit that referenced this pull request May 17, 2017
fix mistake in docs. CanDeactivate should be CanLoad
smurfy pushed a commit to smurfy/angular that referenced this pull request Jun 8, 2017
fix mistake in docs. CanDeactivate should be CanLoad
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
fix mistake in docs. CanDeactivate should be CanLoad
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
fix mistake in docs. CanDeactivate should be CanLoad
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants