docs(router): Change CanDeactivate to CanLoad#16237
Merged
jasonaden merged 1 commit intoangular:masterfrom May 10, 2017
Merged
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1a100af to
e0db1fa
Compare
fix mistake in docs. CanDeactivate should be CanLoad
e0db1fa to
d5ff1c1
Compare
|
CLAs look good, thanks! |
Contributor
|
LGTM |
jasonaden
approved these changes
May 10, 2017
jasonaden
pushed a commit
that referenced
this pull request
May 17, 2017
fix mistake in docs. CanDeactivate should be CanLoad
smurfy
pushed a commit
to smurfy/angular
that referenced
this pull request
Jun 8, 2017
fix mistake in docs. CanDeactivate should be CanLoad
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
fix mistake in docs. CanDeactivate should be CanLoad
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
fix mistake in docs. CanDeactivate should be CanLoad
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix mistake in docs, CanDeactivate should be CanLoad
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Docs contain
CanDeactivatewhere they should containCanLoad.What is the new behavior?
Docs contain
CanLoad.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: