Skip to content

Conversation

@benbraou
Copy link
Contributor

@benbraou benbraou commented Nov 27, 2017

Fixes #20628

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #20628

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@gkalpak gkalpak added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 28, 2017
@mary-poppins
Copy link

You can preview 77dc0ba at https://pr20647-77dc0ba.ngbuilds.io/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same number (e.g. 1) works as well for creating number lists (and makes it easier to re-order or add/remove items). (As you can see in the preview, changing to 1,2,3 doesn't fix the actual issue.
Maybe there needs to be an empty line above the list. Can you make this change and see if it helps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having took the time to review. I have checked the readme for Angular documentation project and see now how to preview the changes...
Indeed, an empty line is missing.

@mary-poppins
Copy link

You can preview 5eeb2cf at https://pr20647-5eeb2cf.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 49f6832 at https://pr20647-49f6832.ngbuilds.io/.

@benbraou
Copy link
Contributor Author

benbraou commented Dec 2, 2017

@gkalpak are you ok with the change now?

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very OK 😃

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2017
@IgorMinar IgorMinar closed this in f092a7c Dec 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numbering bug in documentation of Angular 5

4 participants