-
Notifications
You must be signed in to change notification settings - Fork 27k
docs(aio):fix numbering of the three ways to access hero details #20647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can preview 77dc0ba at https://pr20647-77dc0ba.ngbuilds.io/. |
aio/content/tutorial/toh-pt5.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the same number (e.g. 1) works as well for creating number lists (and makes it easier to re-order or add/remove items). (As you can see in the preview, changing to 1,2,3 doesn't fix the actual issue.
Maybe there needs to be an empty line above the list. Can you make this change and see if it helps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having took the time to review. I have checked the readme for Angular documentation project and see now how to preview the changes...
Indeed, an empty line is missing.
|
You can preview 5eeb2cf at https://pr20647-5eeb2cf.ngbuilds.io/. |
|
You can preview 49f6832 at https://pr20647-49f6832.ngbuilds.io/. |
|
@gkalpak are you ok with the change now? |
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very OK 😃
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #20628
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #20628
What is the new behavior?
Does this PR introduce a breaking change?
Other information