Skip to content

build: upgrade to Bazel 0.8#20807

Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:rules_sass
Closed

build: upgrade to Bazel 0.8#20807
alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle:rules_sass

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@alexeagle alexeagle requested a review from IgorMinar December 5, 2017 19:36
@alexeagle alexeagle force-pushed the rules_sass branch 3 times, most recently from 656cc9b to 7baace8 Compare December 5, 2017 22:06
@mary-poppins
Copy link
Copy Markdown

You can preview 7baace8 at https://pr20807-7baace8.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

You can preview e5ce26f at https://pr20807-e5ce26f.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

You can preview 598d478 at https://pr20807-598d478.ngbuilds.io/.

Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good if CI passes.

Also please add Closes #20807 to the commit message.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just to log version info?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 5, 2017
@mary-poppins
Copy link
Copy Markdown

You can preview b5d0d13 at https://pr20807-b5d0d13.ngbuilds.io/.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 6, 2017
@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
IgorMinar pushed a commit that referenced this pull request Dec 6, 2017
@IgorMinar IgorMinar closed this in 6790e02 Dec 6, 2017
mgol added a commit to mgol/angular that referenced this pull request Dec 6, 2017
PR angular#20807 changed Node version used in CI but it hasn't touched `.nvmrc`. This PR fixes that.

Ref angular#20807
@mgol mgol mentioned this pull request Dec 6, 2017
1 task
@mgol
Copy link
Copy Markdown
Member

mgol commented Dec 6, 2017

I submitted a followup PR as .nvmrc was not modified in this one. See #20831.

mgol added a commit to mgol/angular.js that referenced this pull request Dec 6, 2017
Angular (2+) switched to Node 8 and so should we.

Ref angular/angular#20807
Ref angular/angular#20832
mgol added a commit to mgol/angular.js that referenced this pull request Dec 6, 2017
Angular (2+) switched to Node 8 and so should we.

Ref angular/angular#20807
Ref angular/angular#20832
mgol added a commit to mgol/angular.js that referenced this pull request Dec 6, 2017
Angular (2+) switched to Node 8 and so should we.

Ref angular/angular#20807
Ref angular/angular#20832
mgol added a commit to angular/angular.js that referenced this pull request Dec 7, 2017
Angular (2+) switched to Node 8 and so should we.

Closes #16360
Ref angular/angular#20807
Ref angular/angular#20832
mgol added a commit to angular/angular.js that referenced this pull request Dec 7, 2017
Angular (2+) switched to Node 8 and so should we.

Closes #16360
Ref angular/angular#20807
Ref angular/angular#20832
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants