Skip to content

IVY refactoring #22268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vicb wants to merge 7 commits into from
Closed

IVY refactoring #22268

vicb wants to merge 7 commits into from

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Feb 17, 2018

No description provided.

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release comp: ivy labels Feb 17, 2018
@vicb vicb force-pushed the 0216-ivyref branch 4 times, most recently from 19ec1f1 to bc9bfe0 Compare February 17, 2018 12:05
@vicb
Copy link
Contributor Author

vicb commented Feb 17, 2018

cl/186097851

@vicb vicb force-pushed the 0216-ivyref branch 3 times, most recently from 4ae70a8 to b3ec7cb Compare February 18, 2018 23:06
@vicb
Copy link
Contributor Author

vicb commented Feb 19, 2018

http://test/OCL:186097851:BASE:186170382:1519002065534:4019e394

@angular angular deleted a comment from mary-poppins Feb 19, 2018
@angular angular deleted a comment from mary-poppins Feb 19, 2018
@angular angular deleted a comment from mary-poppins Feb 19, 2018
@angular angular deleted a comment from mary-poppins Feb 19, 2018
@angular angular deleted a comment from mary-poppins Feb 19, 2018
@angular angular deleted a comment from mary-poppins Feb 19, 2018
@angular angular deleted a comment from mary-poppins Feb 19, 2018
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 19, 2018
@vicb vicb closed this in 5a14e22 Feb 19, 2018
vicb added a commit that referenced this pull request Feb 19, 2018
@vicb
refactor(ivy): interpolatiom instructions do not support NO_CHANGE at…
c9ebd60 
… input. (#22268)

PR Close #22268
vicb added a commit that referenced this pull request Feb 19, 2018
@vicb
docs(ivy): update the API docs instructions to add details about remo…
31c5c10 
…ving attributes (#22268)

PR Close #22268
vicb added a commit that referenced this pull request Feb 19, 2018
@vicb
refactor(ivy): move get functions next to their underlying variable (#…
d402634 
…22268)

PR Close #22268
vicb added a commit that referenced this pull request Feb 19, 2018
@vicb
refactor(ivy): simplify interpolation instructions (#22268)
9ce495b 
PR Close #22268
vicb added a commit that referenced this pull request Feb 19, 2018
@vicb
fix(ivy): update master with renamings (#22268)
a8b5465 
PR Close #22268
@vicb vicb deleted the 0216-ivyref branch March 6, 2018 22:25
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicb @mhevery @googlebot