build(aio): render whether API classes and members are abstract#22563
Closed
petebacondarwin wants to merge 2 commits intoangular:masterfrom
Closed
build(aio): render whether API classes and members are abstract#22563petebacondarwin wants to merge 2 commits intoangular:masterfrom
petebacondarwin wants to merge 2 commits intoangular:masterfrom
Conversation
petebacondarwin
added
action: review
|
You can preview 646cde8 at https://pr22563-646cde8.ngbuilds.io/. |
gkalpak
approved these changes
Mar 3, 2018
| {%- macro renderMemberSyntax(member, truncateLines) -%} | ||
| {%- if member.accessibility !== 'public' %}{$ member.accessibility $} {% endif -%} | ||
| {%- if member.isAbstract %}abstract {% endif -%} | ||
| {%- if member.isStatic %}static {% endif -%} |
Member
There was a problem hiding this comment.
Optional nit: Extra space after isStatic 🙄
gkalpak
added
action: cleanup
petebacondarwin
added
action: merge
|
You can preview a672065 at https://pr22563-a672065.ngbuilds.io/. |
Contributor
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22537