-
Notifications
You must be signed in to change notification settings - Fork 27k
docs(service-worker): add doc to include updates to the index.html with the new ng add command #23616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can preview 0660306 at https://pr23616-0660306.ngbuilds.io/. |
Brocco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo here, it's gotta be Progressive
|
You can preview e36d8eb at https://pr23616-e36d8eb.ngbuilds.io/. |
|
You can preview a96507d at https://pr23616-a96507d.ngbuilds.io/. |
jenniferfell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify which "installed PWA" because we haven't used that phrase in these docs before. Other comments are optional, but while you're here... :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brocco: Double-checking...we don't need to say that is adds meta tags for Description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with him and he confirmed that the Description meta tag is not added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear reference: We've never mentioned "the installed Progressive Web App (PWA)" using that phrase before. Is this the app/project to which we're currently adding service worker support?
And I don't think we've been clear in the past about what icon file we're adding any why. What's the icon file for? Also....as a developer, I might wonder why you're adding icon files to my app? Is this the file we're talking about: favicon.ico?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that we are referring to the project to which we are adding service worker. And icon files are the app's icons. @Brocco : please confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma: Creates the service worker configuration file called ngsw-config.json, which specifies the caching behaviors and other settings.
Also...maybe add a link from this filename to the doc file about config options?
|
You can preview 759bd8f at https://pr23616-759bd8f.ngbuilds.io/. |
759bd8f to
606db2b
Compare
|
You can preview 606db2b at https://pr23616-606db2b.ngbuilds.io/. |
|
I still think we can be more clear about this item: But we can come back as necessary if others are confused. Nothing technically incorrect or missing. |
|
@IgorMinar Hi. The essentials have been updated. With a pull-approve member approval, I think we can merge. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the doc does not have content that explains updates to the index.html with the
ng add @angular/pwacommand.Issue Number: 23373 #23373
What is the new behavior?
Added doc to explain the updates to index.html file with the
ng add @angular/pwacommandDoes this PR introduce a breaking change?
Other information