Skip to content

Conversation

@brandonroberts
Copy link
Contributor

Closes #23060

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mary-poppins
Copy link

You can preview 47909b1 at https://pr23948-47909b1.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the zips.
(The stackblitz projects seem to be broken, but that could be fixed in another PR.)

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: patch This PR is targeted for the next patch release labels May 16, 2018
@gkalpak
Copy link
Member

gkalpak commented May 17, 2018

BTW, the live examples seem to be broken because StackBlitz doesn't know where to look for app/** stuff required in test.sb.ts. Maybe changing from 'app/...' to from './app/...' would fix it.

@brandonroberts
Copy link
Contributor Author

@gkalpak yea, that fixes it but it works on the V5 examples using app/...

V5 - https://stackblitz.com/angular/ovyxpbjxapo
V6 - https://stackblitz.com/angular/lnajarexvlk

cc: @EricSimons

@gkalpak
Copy link
Member

gkalpak commented May 17, 2018

This is because in v5 we have {"apps": [{"root": "src", ...}], ...} in .angular-cli.json. In v6's angular.json we have "root": "" and StackBlitz doesn't handle src/ as a root for the project (as webpack seems to always do).

@brandonroberts
Copy link
Contributor Author

Yes, we had this same issue with the live example for the router also not recognizing app/... and the StackBlitz team fixed the issue on their end.

@brandonroberts
Copy link
Contributor Author

I opened a separate issue about the StackBlitz zip files as they are broken for V5 and V6. #23962

@brandonroberts brandonroberts changed the title docs(aio): Add missing dependencies and files to testing zip download docs(aio): add missing dependencies and files to testing zip download May 17, 2018
@EricSimons
Copy link

Yeah, what @gkalpak pointed out is the cause of this issue. Unf this one will be a bit harder for us to immediately fix on our end, although we do have some new upgrades we're working on for our bundler/loader that are coming in 2-4wks that will make it possible. In the meantime, swapping the imports to be relative does fix this problem- here's a fork I made: https://stackblitz.com/edit/angular-nfcbbm?file=src/tests.sb.ts

@brandonroberts
Copy link
Contributor Author

Ok. I'll change the paths to be relative.

@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 17, 2018
@ngbot
Copy link

ngbot bot commented May 17, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required status "ci/circleci: build"
    failure missing required status "ci/circleci: lint"
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview a3731cd at https://pr23948-a3731cd.ngbuilds.io/.

@matsko matsko closed this in db2329e May 21, 2018
matsko pushed a commit that referenced this pull request May 21, 2018
mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request May 28, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(testing): not works download example.

5 participants