-
Notifications
You must be signed in to change notification settings - Fork 27k
docs(aio): add missing dependencies and files to testing zip download #23948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aio): add missing dependencies and files to testing zip download #23948
Conversation
|
You can preview 47909b1 at https://pr23948-47909b1.ngbuilds.io/. |
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the zips.
(The stackblitz projects seem to be broken, but that could be fixed in another PR.)
|
BTW, the live examples seem to be broken because StackBlitz doesn't know where to look for |
|
@gkalpak yea, that fixes it but it works on the V5 examples using V5 - https://stackblitz.com/angular/ovyxpbjxapo cc: @EricSimons |
|
This is because in v5 we have |
|
Yes, we had this same issue with the live example for the router also not recognizing |
|
I opened a separate issue about the StackBlitz zip files as they are broken for V5 and V6. #23962 |
|
Yeah, what @gkalpak pointed out is the cause of this issue. Unf this one will be a bit harder for us to immediately fix on our end, although we do have some new upgrades we're working on for our bundler/loader that are coming in 2-4wks that will make it possible. In the meantime, swapping the imports to be relative does fix this problem- here's a fork I made: https://stackblitz.com/edit/angular-nfcbbm?file=src/tests.sb.ts |
|
Ok. I'll change the paths to be relative. |
|
You can preview a3731cd at https://pr23948-a3731cd.ngbuilds.io/. |
…nload (angular#23948) Closes angular#23060 PR Close angular#23948
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |


Closes #23060
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information