Skip to content

docs: refactor feature modules example#25069

Closed
danielsogl wants to merge 1 commit intoangular:masterfrom
danielsogl:aio_feature-modules_http
Closed

docs: refactor feature modules example#25069
danielsogl wants to merge 1 commit intoangular:masterfrom
danielsogl:aio_feature-modules_http

Conversation

@danielsogl
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The angular/http is deprecated

What is the new behavior?

Replaced the deprecated angular/http module import by angular/common/http module

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@danielsogl
Copy link
Contributor Author

cc @brandonroberts

@brandonroberts brandonroberts added comp: docs target: patch This PR is targeted for the next patch release state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 25, 2018
@brandonroberts brandonroberts self-assigned this Jul 25, 2018
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jul 27, 2018
IgorMinar pushed a commit that referenced this pull request Jul 27, 2018
@IgorMinar IgorMinar closed this in a3cf61b Jul 27, 2018
@danielsogl danielsogl deleted the aio_feature-modules_http branch July 27, 2018 17:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants