Skip to content

docs: fix typo in service worker getting started guide#25512

Closed
FrankiePo wants to merge 1 commit intoangular:masterfrom
FrankiePo:patch-3
Closed

docs: fix typo in service worker getting started guide#25512
FrankiePo wants to merge 1 commit intoangular:masterfrom
FrankiePo:patch-3

Conversation

@FrankiePo
Copy link
Contributor

@FrankiePo FrankiePo commented Aug 16, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts brandonroberts self-assigned this Aug 16, 2018
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the git commit message to docs: fix typo in service worker getting started guide

@brandonroberts brandonroberts added comp: docs target: patch This PR is targeted for the next patch release area: service-worker Issues related to the @angular/service-worker package state: community Someone from the Angular community is working on this issue or submitted this PR action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 16, 2018
@FrankiePo
Copy link
Contributor Author

@brandonroberts done

@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 17, 2018
@brandonroberts brandonroberts changed the title docs(aio): fix typo docs: fix typo in service worker getting started guide Aug 17, 2018
@brandonroberts brandonroberts added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 17, 2018
@brandonroberts brandonroberts requested review from gkalpak and removed request for IgorMinar and jenniferfell August 20, 2018 13:23
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 20, 2018
@jasonaden jasonaden closed this in b05d4a5 Aug 20, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants