Skip to content

fix(docs-infra): add hamburger button to CLI COMMANDS#28418

Closed
wKoza wants to merge 2 commits intoangular:masterfrom
wKoza:add_hamburger_folder_cli
Closed

fix(docs-infra): add hamburger button to CLI COMMANDS#28418
wKoza wants to merge 2 commits intoangular:masterfrom
wKoza:add_hamburger_folder_cli

Conversation

@wKoza
Copy link
Copy Markdown
Contributor

@wKoza wKoza commented Jan 29, 2019

Currently, when we navigate in the CLI COMMANDS section, the "hamburger button" isn't present because the class css folder-cli is missing.
This PR add this class in order to show this button when we are in this section.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Currently, when we navigate in the `CLI COMMANDS` section, the "hamburger button" isn't present because the class css `folder-cli` is missing.
This PR add this class in order to show this button when we are in this section.
@wKoza wKoza requested a review from a team January 29, 2019 10:34
Copy link
Copy Markdown
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😱

Comment thread aio/src/styles/1-layouts/_top-menu.scss Outdated
@gkalpak gkalpak added type: bug/fix action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs-infra target: patch This PR is targeted for the next patch release labels Jan 29, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 29, 2019
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 29, 2019
@jasonaden jasonaden closed this in b87bf39 Jan 29, 2019
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
Currently, when we navigate in the `CLI COMMANDS` section, the "hamburger button" isn't present because the class css `folder-cli` is missing.
This PR add this class in order to show this button when we are in this section.

PR Close #28418
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
…r#28418)

Currently, when we navigate in the `CLI COMMANDS` section, the "hamburger button" isn't present because the class css `folder-cli` is missing.
This PR add this class in order to show this button when we are in this section.

PR Close angular#28418
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants