test: improve language service tests performance#30585
test: improve language service tests performance#30585alan-agius4 wants to merge 1 commit intoangular:masterfrom alan-agius4:perf-language-service-specs
Conversation
|
On codefresh CI Before With the change That shaves off approx 3mins //cc @filipesilva |
With this change we reduce the amount of IO operations. This is especially a huge factor in windows since IO ops are slower. With this change mainly we cache `existsSync` and `readFileSync` calls Here's the results Before ``` //packages/language-service/test:test INFO: Elapsed time: 258.755s, Critical Path: 253.91s ``` After ``` //packages/language-service/test:test INFO: Elapsed time: 66.403s, Critical Path: 63.13s ```
|
Is it right that this is master only PR? |
|
@IgorMinar, no it’s should be master & patch. Thanks for highlighting it. |
With this change we reduce the amount of IO operations. This is especially a huge factor in windows since IO ops are slower. With this change mainly we cache `existsSync` and `readFileSync` calls Here's the results Before ``` //packages/language-service/test:test INFO: Elapsed time: 258.755s, Critical Path: 253.91s ``` After ``` //packages/language-service/test:test INFO: Elapsed time: 66.403s, Critical Path: 63.13s ``` PR Close angular#30585
|
@alan-agius4 @IgorMinar I merged this only to master ... let me know if this was the correct thing to do. |
|
@matsko, can you please merge it to patch as well? Or it doesn’t apply cleanly? |
|
It doesn't apply cleanly. Can you create another PR based on the |
|
Patch being |
|
@matsko, yes, will do that on Monday and I’ll ping you, as I away for the weekend. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With this change we reduce the amount of IO operations. This is especially a huge factor in windows since IO ops are slower.
With this change mainly we cache
existsSyncandreadFileSynccallsHere's the results
Before
After