ci: remove unused artifact uploads from test job#32292
Closed
josephperrott wants to merge 1 commit intoangular:masterfrom
Closed
ci: remove unused artifact uploads from test job#32292josephperrott wants to merge 1 commit intoangular:masterfrom
josephperrott wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
Thanks @josephperrott! 👍 |
AndrewKushnir
approved these changes
Aug 23, 2019
josephperrott
added
area: build & ci
josephperrott
added
the
target: patch
Member
|
For reference, the artifacts were uploaded so that "CircleCI will parse the provided XML files to provide a better UI for looking at karma error messages" (see #31100). |
These were initally added to allow for CircleCI to provide a better failure UI using junit data. This information is not currently being created for bazel tests and once it is created it will be available on the cloud status pages created by the BEP for each bazel execution.
josephperrott
force-pushed
the
remove-artifacts
branch
from
e262a82 to
853483e
Compare
Member
Author
|
Good point, added to the commit message with more info. |
atscott
added
target: major
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
These were initally added to allow for CircleCI to provide a better failure UI using junit data. This information is not currently being created for bazel tests and once it is created it will be available on the cloud status pages created by the BEP for each bazel execution. PR Close angular#32292
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @AndrewKushnir - I discovered we can remove the upload that was taking an unexpectedly long time