Skip to content

refactor(router): Add handling of abort event on signal of NavigateEvent#64974

Merged
AndrewKushnir merged 1 commit intoangular:mainfrom
atscott:addAbortHandler
Nov 10, 2025
Merged

refactor(router): Add handling of abort event on signal of NavigateEvent#64974
AndrewKushnir merged 1 commit intoangular:mainfrom
atscott:addAbortHandler

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Nov 6, 2025

This adds handling of the abort event on the signal of the
NavigateEvent, allowing us to cancel the Router's ongoing navigation
transition when its related navigation was aborted.

@angular-robot angular-robot Bot added area: core Issues related to the framework runtime area: router labels Nov 6, 2025
@ngbot ngbot Bot added this to the Backlog milestone Nov 6, 2025
@atscott atscott marked this pull request as ready for review November 7, 2025 22:56
@atscott atscott added the target: minor This PR is targeted for the next minor release label Nov 7, 2025
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott force-pushed the addAbortHandler branch 2 times, most recently from 73a97f7 to b077133 Compare November 8, 2025 18:11
This adds handling of the abort event on the signal of the
`NavigateEvent`, allowing us to cancel the Router's ongoing navigation
transition when its related navigation was aborted.
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Nov 9, 2025
@AndrewKushnir AndrewKushnir merged commit 2db8f2e into angular:main Nov 10, 2025
20 checks passed
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: router target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants