Skip to content

docs(docs-infra): fix aria-label parsing breaking headings#67787

Merged
leonsenft merged 1 commit into
angular:mainfrom
SkyZeroZx:docs/docs-infra-heading-fix
Mar 23, 2026
Merged

docs(docs-infra): fix aria-label parsing breaking headings#67787
leonsenft merged 1 commit into
angular:mainfrom
SkyZeroZx:docs/docs-infra-heading-fix

Conversation

@SkyZeroZx
Copy link
Copy Markdown
Contributor

Strip all HTML tags and escape quotes in aria-label to avoid breakage

What is the current behavior?

See https://next.angular.dev/ai/ai-tutor#phase-5-experimental-signal-forms--warning-subject-to-change

image image

What is the new behavior?

image image

@pullapprove pullapprove Bot requested a review from MarkTechson March 21, 2026 17:30
@angular-robot angular-robot Bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Mar 21, 2026
@ngbot ngbot Bot added this to the Backlog milestone Mar 21, 2026
Strip all HTML tags and escape quotes in aria-label to avoid breakage
@SkyZeroZx SkyZeroZx force-pushed the docs/docs-infra-heading-fix branch from 9262757 to 0bc196d Compare March 21, 2026 17:31
@JeanMeche JeanMeche added memory leak Issue related to a memory leak target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed memory leak Issue related to a memory leak labels Mar 21, 2026
@JeanMeche JeanMeche removed the request for review from MarkTechson March 21, 2026 18:55
@leonsenft leonsenft merged commit 6d2eed6 into angular:main Mar 23, 2026
22 checks passed
@leonsenft
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants