Skip to content

Conversation

@sandbergja
Copy link
Contributor

This commit adds a missing word to the section on alternate build
configurations.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The sentence reads "The production configuration sets defaults that optimize the app in a number of ways, such bundling files[...]"

Issue Number: N/A

What is the new behavior?

The sentence includes the word "as" between "such" and "bundling".

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This commit adds a missing word to the section on alternate build
configurations.
@sandbergja sandbergja requested a review from a team July 18, 2019 18:04
@ngbot ngbot bot added this to the Backlog milestone Jul 18, 2019
@kapunahelewong kapunahelewong added target: patch This PR is targeted for the next patch release aio: preview labels Jul 18, 2019
@kapunahelewong
Copy link
Contributor

Hi @sandbergja! Thanks for this! As soon as the tests pass, will you tag me here so I can help it move to the next phase? Good catch! 🙂

@mary-poppins
Copy link

You can preview 5724ede at https://pr31630-5724ede.ngbuilds.io/.

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @sandbergja!

@kapunahelewong kapunahelewong added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 18, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jul 18, 2019
mhevery pushed a commit that referenced this pull request Jul 18, 2019
This commit adds a missing word to the section on alternate build
configurations.

PR Close #31630
@mhevery mhevery closed this in 1b6e841 Jul 18, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
This commit adds a missing word to the section on alternate build
configurations.

PR Close angular#31630
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants