Skip to content

Refactor global state for performance (and sanity) #33093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhevery wants to merge 1 commit into from
Closed

Refactor global state for performance (and sanity) #33093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration/_payload-limits.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"master": {
"uncompressed": {
"runtime": 1440,
"main": 13415,
"main": 14228,
"polyfills": 45340
}
}
Expand All @@ -21,7 +21,7 @@
"master": {
"uncompressed": {
"runtime": 1440,
"main": 123904,
"main": 125674,
Copy link
Contributor

@kara kara Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this number regressed by 1KB? Size creep?

Copy link
Contributor Author

@mhevery mhevery Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we move things from closure variables which are minifiable to object properties which are not. In that sense this is expected. We will have to come up with some way of minifing these. I think using --mangle-props with some regexp should do the trick.

"polyfills": 45340
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/render3/instructions/styling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function stylingProp(
// it's important we remove the current style sanitizer once the
// element exits, otherwise it will be used by the next styling
// instructions for the next element.
setElementExitFn(resetCurrentStyleSanitizer);
setElementExitFn(stylingApply);
}
} else {
// Context Resolution (or first update) Case: save the value
Expand Down Expand Up @@ -354,7 +354,7 @@ function _stylingMap(
// it's important we remove the current style sanitizer once the
// element exits, otherwise it will be used by the next styling
// instructions for the next element.
setElementExitFn(resetCurrentStyleSanitizer);
setElementExitFn(stylingApply);
}
} else {
updated = valueHasChanged;
Expand Down
Loading