refactor(compiler-cli): move downlevel decorators transform into ngtsc #44909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
target: patch
JoostK
force-pushed
the
ngtsc/restructuring
branch
from
2af843a to
6237234
Compare
JoostK
added
the
action: review
pullapprove
bot
requested review from
alan-agius4,
clydin,
dgp1130 and
gkalpak
Member
Author
|
Note to reviewer: unfortunately the whitespace changes are causing too much differences for the spec file rename to be considered as rename; use git diff -M30% -w 6237234b9cf02558b12e5521633e18b62daf433c~ 6237234b9cf02558b12e5521633e18b62daf433cto see a readable diff. |
alan-agius4
approved these changes
Feb 16, 2022
dgp1130
approved these changes
Feb 23, 2022
dgp1130
previously approved these changes
Feb 24, 2022
Contributor
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Reviewed-for: tooling-cli-shared-api
alan-agius4
previously approved these changes
Feb 24, 2022
Contributor
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
Reviewed-for: tooling-cli-shared-api
JoostK
force-pushed
the
ngtsc/restructuring
branch
2 times, most recently
from
69017ad to
b654f77
Compare
Contributor
|
@JoostK It looks like this was approved and never merged. Is this something you still want to merge? |
Member
Author
|
Yes, I shall rebase! Some more approvals are needed though. |
JoostK
force-pushed
the
ngtsc/restructuring
branch
from
b654f77 to
ed22ea1
Compare
This commit moves the `downlevel_decorators_transform` into a dedicated compilation unit within `ngtsc`. The tests were refactored to move to ngtsc's testing abstractions, allowing VE's `MockAotContext` and `MockCompilerHost` to be removed.
JoostK
force-pushed
the
ngtsc/restructuring
branch
from
ed22ea1 to
153f84d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the
downlevel_decorators_transforminto a dedicatedcompilation unit within
ngtsc.The tests were refactored to move to ngtsc's testing abstractions, allowing
VE's
MockAotContextandMockCompilerHostto be removed.