feat(core): desugar [()] to [prop] and (prop-change)

[vsavkin]

BREAKING CHANGE

Before <cmp [(prop)]="field"> was desugared to <cmp [prop]="field" (prop)="field=$event">
After <cmp [(prop)]="field"> was desugared to <cmp [prop]="field" (prop-change)="field=$event">

[mhevery]

For upgrade

1. find ExportedNg1Component.extractBindings
2. find var outputNameRename = outputName + ': ' + name;
3. add var outputNameRenameChange = outputName + ': ' + name + 'Change';
4. change this.outputsRename.push(outputNameRename); => this.outputsRename.push(outputNameRenameChange);
5. in integration_spec.ts change twoWayBEmitter: twoWayB => twoWayBEmitter: twoWayBChanged here

I think...

[pkozlowski-opensource]

Could you add backticks around code samples in the commit message so it shows correctly in the changelog?

[mhevery]

Also I think you need to rebase.

[mary-poppins]

Merging PR #4658 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4658.

[rkj]

Could you provide any rationale why this was changed? Should all events be named with -change suffix moving on?

[0x-r4bbit]

No, not all events have to have -change suffix. Only the ones that can be
used with 2-way binding syntax.

I think the reason for this change was just for semantic reasons. Before
this change, an event that is being used with 2-way syntax would be named
like the property. Having -change as suffix makes it semantically an
action. So this makes sense.

On Tue, Nov 24, 2015, 7:49 PM Roman notifications@github.com wrote:

Could you provide any rationale why this was changed? Should all events be
named with -change suffix moving on?

—
Reply to this email directly or view it on GitHub
#4658 (comment).

[rkj]

Well, we still have events named like properties, just we need to change them depending if we want to use 2-way binding sugar. Thanks for comments!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}