Skip to content

refactor(http): Don't log fetch warning in tests. #59049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(http): Don't log fetch warning in tests. #59049

wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Dec 4, 2024

Prior to this commit, we were logging the NOT_USING_FETCH_BACKEND_IN_SSR error when provideHttpTestingClient and PLATFORM_ID were provided.

fixes #59028

@pullapprove pullapprove bot requested a review from alxhub December 4, 2024 16:57
@JeanMeche JeanMeche removed the request for review from alxhub December 4, 2024 17:09
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Dec 4, 2024
@pkozlowski-opensource pkozlowski-opensource added the area: common/http Issues related to HTTP and HTTP Client label Dec 4, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 4, 2024
@JoostK
Copy link
Member

JoostK commented Dec 4, 2024

I'd be surprised if this worked in a packaged environment (also confirmed by the broken tests): @angular/common/http/testing is its own entry-point so the relative import from @angular/common/http is invalid. I think you'd need a magic property on HttpClientTestingBackend that can be detected without having to cross the entry-point boundary.

@JoostK JoostK added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 4, 2024
@JeanMeche JeanMeche force-pushed the refactor/http-testing-warning branch from bcf5277 to 301816c Compare December 4, 2024 21:58
@angular-robot angular-robot bot removed the area: common/http Issues related to HTTP and HTTP Client label Dec 4, 2024
@ngbot ngbot bot removed this from the Backlog milestone Dec 4, 2024
AndrewKushnir
AndrewKushnir reviewed Dec 4, 2024
View reviewed changes
@JeanMeche JeanMeche force-pushed the refactor/http-testing-warning branch from 301816c to 8c3567f Compare December 5, 2024 00:42
AndrewKushnir
AndrewKushnir reviewed Dec 5, 2024
View reviewed changes
@JeanMeche
refactor(http): Don't log fetch warning in tests.
6bdec41 
Prior to this commit, we were logging the `NOT_USING_FETCH_BACKEND_IN_SSR` error when `provideHttpTestingClient` and `PLATFORM_ID` were provided.

fixes angular#59028
@JeanMeche JeanMeche force-pushed the refactor/http-testing-warning branch from 8c3567f to 6bdec41 Compare December 5, 2024 00:50
AndrewKushnir
AndrewKushnir approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche thanks for the improvement! 👍

@AndrewKushnir AndrewKushnir removed the request for review from thePunderWoman December 5, 2024 00:54
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 5, 2024
@AndrewKushnir AndrewKushnir added area: common/http Issues related to HTTP and HTTP Client action: presubmit The PR is in need of a google3 presubmit labels Dec 5, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 5, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Dec 5, 2024

Presubmit.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Dec 5, 2024
@alxhub
Copy link
Member

alxhub commented Dec 6, 2024

This PR was merged into the repository by commit 0034ce5.

The changes were merged into the following branches: main, 19.0.x

alxhub pushed a commit that referenced this pull request Dec 6, 2024
@JeanMeche @alxhub
refactor(http): Don't log fetch warning in tests. (#59049)
ffae7df 
Prior to this commit, we were logging the `NOT_USING_FETCH_BACKEND_IN_SSR` error when `provideHttpTestingClient` and `PLATFORM_ID` were provided.

fixes #59028

PR Close #59049
@alxhub alxhub closed this in 0034ce5 Dec 6, 2024
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 6, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 6, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@JeanMeche @PrajaktaB27
refactor(http): Don't log fetch warning in tests. (angular#59049)
f94848f 
Prior to this commit, we were logging the `NOT_USING_FETCH_BACKEND_IN_SSR` error when `provideHttpTestingClient` and `PLATFORM_ID` were provided.

fixes angular#59028

PR Close angular#59049
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

NG02801 raised during unit tests even if withFetch() is provided

6 participants

@JeanMeche @JoostK @AndrewKushnir @alxhub @thePunderWoman @pkozlowski-opensource