Skip to content

Revert "refactor: initialize headers map directly in HttpHeaders class (#59268)" #59523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "refactor: initialize headers map directly in HttpHeaders class (#59268)" #59523

wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Jan 14, 2025

This reverts commit e15226a due to some breakages internally.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: common/http Issues related to HTTP and HTTP Client labels Jan 14, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 14, 2025
@AndrewKushnir AndrewKushnir requested a review from kirjs January 14, 2025 22:38
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Jan 14, 2025

Presubmit is "green".

@kirjs
Copy link
Contributor

kirjs commented Jan 14, 2025

This PR was merged into the repository by commit eadf6a3.

The changes were merged into the following branches: main, 19.0.x, 19.1.x

@kirjs kirjs closed this in eadf6a3 Jan 14, 2025
kirjs pushed a commit that referenced this pull request Jan 14, 2025
@AndrewKushnir @kirjs
Revert "refactor: initialize headers map directly in HttpHeaders class (
990ce59 
#59268)" (#59523)

This reverts commit e15226a.

PR Close #59523
kirjs pushed a commit that referenced this pull request Jan 14, 2025
@AndrewKushnir @kirjs
Revert "refactor: initialize headers map directly in HttpHeaders class (
6a0dd96 
#59268)" (#59523)

This reverts commit e15226a.

PR Close #59523
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@AndrewKushnir @PrajaktaB27
Revert "refactor: initialize headers map directly in HttpHeaders class (
11d094a 
angular#59268)" (angular#59523)

This reverts commit e15226a.

PR Close angular#59523
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 14, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirjs kirjs kirjs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewKushnir @kirjs