Skip to content

fix(animations): account for Element.animate exceptions #64506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(animations): account for Element.animate exceptions #64506

wants to merge 1 commit into from
+97 −20

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented Oct 17, 2025

In certain scenarios Element.animate fails, manifesting in an exception (Firefox) or a null return value (Chromium). The null value is not conform WebIDL but handled gracefully in this commit regardless.

Closes #64486

@JoostK
fix(animations): account for Element.animate exceptions
e88a65d 
In certain scenarios `Element.animate` fails, manifesting in an exception (Firefox)
or a null return value (Chromium). The null value is not conform WebIDL but handled
gracefully in this commit regardless.

Closes angular#64486
@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 17, 2025
@pullapprove pullapprove bot requested a review from JeanMeche October 17, 2025 20:16
@ngbot ngbot bot added this to the Backlog milestone Oct 17, 2025
@JoostK JoostK mentioned this pull request Oct 17, 2025
Closed
@JeanMeche JeanMeche added the requires: TGP This PR requires a passing TGP before merging is allowed label Oct 17, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Oct 17, 2025
@thePunderWoman thePunderWoman added the action: global presubmit The PR is in need of a google3 global presubmit label Oct 20, 2025
@JeanMeche
Copy link
Member

That TGP wasn't passing over the week-end because of the diagnostic issue but it should be fine now

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2025
@ngbot
Copy link

ngbot bot commented Oct 21, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman removed the action: global presubmit The PR is in need of a google3 global presubmit label Oct 21, 2025
thePunderWoman pushed a commit that referenced this pull request Oct 21, 2025
@JoostK @thePunderWoman
fix(animations): account for Element.animate exceptions (#64506)
bd38cd4 
In certain scenarios `Element.animate` fails, manifesting in an exception (Firefox)
or a null return value (Chromium). The null value is not conform WebIDL but handled
gracefully in this commit regardless.

Closes #64486

PR Close #64506
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: animations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Element.animate can return null in Chromium browsers

3 participants

@JoostK @JeanMeche @thePunderWoman