Skip to content

Conversation

@portneon
Copy link
Contributor

@portneon portneon commented Nov 16, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from bencodezen November 16, 2025 05:06
@angular-robot angular-robot bot added area: docs Related to the documentation area: router labels Nov 16, 2025
@ngbot ngbot bot modified the milestone: Backlog Nov 16, 2025
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@JeanMeche JeanMeche removed the request for review from bencodezen November 16, 2025 08:41
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 16, 2025
@portneon
Copy link
Contributor Author

Thanks for this
It’s my pleasure, sir. Thank you for maintaining such a useful product.

@thePunderWoman thePunderWoman merged commit 93d548f into angular:main Nov 17, 2025
23 checks passed
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: router target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect event.reason comparison on error-handling Router Example Docs

3 participants