refactor(google-maps): use directive for map marker #19641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
The Google Maps marker is currently marked as a component, but it isn't using any component features. These changes turn it into a directive since it also allows consumers to apply it on elements that are components.
crisbeto
force-pushed
the
map-marker-directive
branch
from
5f066c9 to
e0ad72d
Compare
jelbourn
approved these changes
Jun 16, 2020
mbehrlich
approved these changes
Jun 17, 2020
jelbourn
pushed a commit
that referenced
this pull request
Jun 29, 2020
The Google Maps marker is currently marked as a component, but it isn't using any component features. These changes turn it into a directive since it also allows consumers to apply it on elements that are components.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Maps marker is currently marked as a component, but it isn't using any component features. These changes turn it into a directive since it also allows consumers to apply it on elements that are components.
Note for reviewer: I don't know whether we should mark this as a breaking change, because on one hand the public API is the same, but on the other it could affect consumers that have implicit template references.
cc @mbehrlich