build: add support for shorthand names in API golden approval script #20394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Aug 24, 2020
Currently we have to write the full path for the API golden approval script, whereas the `test` script supports shorthands. These changes move the logic that guesses the name of a package out into a separate file so that it can be reused in the `approve-api` script.
crisbeto
force-pushed
the
api-golden-name-guess
branch
from
710474d to
8b3d1e6
Compare
devversion
approved these changes
Aug 25, 2020
|
For a follow up we should add this to the dev docs |
jelbourn
pushed a commit
that referenced
this pull request
Aug 28, 2020
…20394) Currently we have to write the full path for the API golden approval script, whereas the `test` script supports shorthands. These changes move the logic that guesses the name of a package out into a separate file so that it can be reused in the `approve-api` script. (cherry picked from commit 54218cd)
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
…ngular#20394) Currently we have to write the full path for the API golden approval script, whereas the `test` script supports shorthands. These changes move the logic that guesses the name of a package out into a separate file so that it can be reused in the `approve-api` script.
mmalerba
pushed a commit
that referenced
this pull request
Sep 2, 2020
…20394) Currently we have to write the full path for the API golden approval script, whereas the `test` script supports shorthands. These changes move the logic that guesses the name of a package out into a separate file so that it can be reused in the `approve-api` script.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have to write the full path for the API golden approval script, whereas the
testscript supports shorthands. These changes move the logic that guesses the name of a package out into a separate file so that it can be reused in theapprove-apiscript.