docs: add missing standards for building components #22412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Apr 6, 2021
wagnermaciel
commented
- Naming conventions for the selectors of components & directives
- The tests & public APIs for MDC components should mirror the non-MDC version
- Public properties should use coercion
wagnermaciel
requested review from
andrewseguin,
crisbeto,
jelbourn and
mmalerba
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Apr 6, 2021
wagnermaciel
added
the
target: patch
mmalerba
approved these changes
Apr 6, 2021
jelbourn
reviewed
Apr 7, 2021
* Naming conventions for the selectors of components & directives * The tests & public APIs for MDC components should mirror the non-MDC version * Public properties should use coercion
wagnermaciel
force-pushed
the
coding-standards
branch
from
29bdc6e to
65894bd
Compare
jelbourn
added
docs
mmalerba
pushed a commit
that referenced
this pull request
Apr 8, 2021
* docs: add missing standards for building components * Naming conventions for the selectors of components & directives * The tests & public APIs for MDC components should mirror the non-MDC version * Public properties should use coercion * fixup! docs: add missing standards for building components * fixup! docs: add missing standards for building components * fixup! docs: add missing standards for building components (cherry picked from commit 60946cc)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.