fix(material/form-field) : correct placeholder-shown pseudo class #24183
Conversation
fix(material/form-field) : correct placeholder-shown pseudo class Replace an invalid pseudo class `:label-shown` for a valid `:placeholder-shown` to correct styles of a form-field label Fixes #24181
| // Server-side rendered matInput with a label attribute but label not shown | ||
| // (used as a pure CSS stand-in for mat-form-field-should-float). | ||
| .mat-input-server[label]:not(:label-shown) + .mat-form-field-label-wrapper | ||
| .mat-input-server[label]:not(:placeholder-shown) + .mat-form-field-label-wrapper |
There was a problem hiding this comment.
I think we should remove all the :not(:placeholder-shown) usages altogether. The recommended approach for labelling inputs has been using mat-label for a long time now.
There was a problem hiding this comment.
Shall we just remove all these rules then? I guess they should not work anyway (see my tiny copen)
Nevertheless, couldn't we just fix the obvious bug(reverting the pseudo-selector) and handle any further optimizations afterwards?
There was a problem hiding this comment.
I would rather keep the selectors without the :not. It's possible that this was a regression the entire time, but we never noticed it.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
fix(material/form-field) : correct placeholder-shown pseudo class
Replace an invalid pseudo class
:label-shownby a valid:placeholder-shownpseudo class to correct styles of a form-field labelFixes #24181