Second iteration of rules_js migration
#30648
Merged
+2,455
−2,266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
rjs-2
branch
5 times, most recently
from
0496438 to
4d7bd95
Compare
For linking of Angular packages we are using something more clever than what we are doing with `rules_nodejs`. Instead of maintaing complexity where we pre-link FESM bundles and somehow inject them into other Bazel bundling steps (with complex linker mappings), we pre-link as part of individual package postinstall steps, exposing the linked bundles via a NodeJS exports condition. This is possible vis this package/script: https://github.com/devversion/angular-linking Clearly this is not at a good location, but it's necessary right now to ship this code via npm because `rules_js` struggles to use pnpm extensions onto workspace 1st-party packages. Long-term we can either decide to keep it that way, move it into e.g. dev-infra repository, or we can explore shipping pre-linked bundles via APF. TBD.
devversion
added
the
target: patch
devversion
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
andrewseguin
approved these changes
Mar 19, 2025
Migrates all `ts_library` targets in `tools/` to use the `rules_js` `ts_project` rule.
Improves the `ts_project` interop to work with Esbuild bundling. Right now we can end up with multiple copies of the same source file. e.g. input might import from `@angular/cdk/testing` and end up with the version of `rules_nodejs` linker, while other imports to the native `ts_library` targets end up being mapped to their actual sources in the `bazel-bin`, and not inside `node_modules`
Migrates more `ts_library` targets to `rules_js`
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits