Migrate integration tests #30853
Merged
Migrate integration tests #30853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes code duplication
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
integration-test-rjs
branch
from
47d079f to
03455ab
Compare
Switchs all integration tests to pnpm, solving one of our annoying bugs when installing integration test deps. It also seems much faster. In the future, we are considering allowing the local profile pnpm cache, even within the Bazel sandbox, but for now we continue installing dependencies via internet. In practice we even install a bit more dependencies now, but that is a trade-off we accept, because it's not making anything worse, but instead allows us to finally: - easily update the lock files manually - let renovate maintain versions of our integration tests; keeping them up-to-date.
Removes remaining `@npm//` usages.
devversion
force-pushed
the
integration-test-rjs
branch
from
03455ab to
5606aac
Compare
devversion
requested review from
andrewseguin and
crisbeto
and removed request for
a team
devversion
added
target: patch
devversion
added
action: merge
devversion
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits