Skip to content

fix(aria/menu): add selectable to inputs #32131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix(aria/menu): add selectable to inputs #32131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/aria/ui-patterns/menu/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface MenuTriggerInputs<V> {
}

/** The inputs for the MenuItemPattern class. */
export interface MenuItemInputs<V> extends Omit<ListItem<V>, 'index'> {
export interface MenuItemInputs<V> extends Omit<ListItem<V>, 'index' | 'selectable'> {
/** A reference to the parent menu or menu trigger. */
parent: SignalLike<MenuPattern<V> | MenuBarPattern<V> | undefined>;

Expand Down Expand Up @@ -635,13 +635,17 @@ export class MenuItemPattern<V> implements ListItem<V> {
/** The submenu associated with the menu item. */
submenu: SignalLike<MenuPattern<V> | undefined>;

/** Whether the menu item is selectable. */
selectable: SignalLike<boolean>;

constructor(readonly inputs: MenuItemInputs<V>) {
this.id = inputs.id;
this.value = inputs.value;
this.element = inputs.element;
this.disabled = inputs.disabled;
this.submenu = this.inputs.submenu;
this.searchTerm = inputs.searchTerm;
this.selectable = computed(() => !this.submenu());
}

/** Opens the submenu. */
Expand Down
Loading